Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(298)

Unified Diff: content/browser/browser_plugin/browser_plugin_embedder_helper.cc

Issue 10965048: [BrowserTag] Send dib info with NavigateGuest message, (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Address comments from Fady + remove commented code. Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/browser_plugin/browser_plugin_embedder_helper.cc
diff --git a/content/browser/browser_plugin/browser_plugin_embedder_helper.cc b/content/browser/browser_plugin/browser_plugin_embedder_helper.cc
index eac62cc7c41e706a2c03dea494fba75ea0c86e65..ce2e2a30d2a09a813a853fff005c24bdd472c0e9 100644
--- a/content/browser/browser_plugin/browser_plugin_embedder_helper.cc
+++ b/content/browser/browser_plugin/browser_plugin_embedder_helper.cc
@@ -53,39 +53,7 @@ bool BrowserPluginEmbedderHelper::OnMessageReceived(
void BrowserPluginEmbedderHelper::OnResizeGuest(
int instance_id,
const BrowserPluginHostMsg_ResizeGuest_Params& params) {
- TransportDIB* damage_buffer = NULL;
-#if defined(OS_WIN)
- // On Windows we need to duplicate the handle from the remote process.
- HANDLE section;
- DuplicateHandle(render_view_host()->GetProcess()->GetHandle(),
- params.damage_buffer_id.handle,
- GetCurrentProcess(),
- &section,
- STANDARD_RIGHTS_REQUIRED | FILE_MAP_READ | FILE_MAP_WRITE,
- FALSE, 0);
- damage_buffer = TransportDIB::Map(section);
-#elif defined(OS_MACOSX)
- // On OSX, the browser allocates all DIBs and keeps a file descriptor around
- // for each.
- damage_buffer = render_view_host()->GetProcess()->
- GetTransportDIB(params.damage_buffer_id);
-#elif defined(OS_ANDROID)
- damage_buffer = TransportDIB::Map(params.damage_buffer_id);
-#elif defined(OS_POSIX)
- damage_buffer = TransportDIB::Map(params.damage_buffer_id.shmkey);
-#endif // defined(OS_POSIX)
- DCHECK(damage_buffer);
- // TODO(fsamuel): Schedule this later so that we don't stall the embedder for
- // too long.
- embedder_->ResizeGuest(instance_id,
- damage_buffer,
-#if defined(OS_WIN)
- params.damage_buffer_size,
-#endif
- params.width,
- params.height,
- params.resize_pending,
- params.scale_factor);
+ embedder_->ResizeGuest(instance_id, params);
}
void BrowserPluginEmbedderHelper::OnHandleInputEvent(
@@ -128,12 +96,16 @@ void BrowserPluginEmbedderHelper::OnHandleInputEvent(
reply_message);
}
-void BrowserPluginEmbedderHelper::OnNavigateGuest(int instance_id,
- int64 frame_id,
- const std::string& src,
- const gfx::Size& size) {
- embedder_->NavigateGuest(render_view_host(), instance_id, frame_id, src,
- size);
+void BrowserPluginEmbedderHelper::OnNavigateGuest(
+ int instance_id,
+ int64 frame_id,
+ const std::string& src,
+ const BrowserPluginHostMsg_ResizeGuest_Params& resize_params) {
+ embedder_->NavigateGuest(render_view_host(),
+ instance_id,
+ frame_id,
+ src,
+ resize_params);
}
void BrowserPluginEmbedderHelper::OnUpdateRectACK(int instance_id,

Powered by Google App Engine
This is Rietveld 408576698