Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2362)

Unified Diff: content/common/browser_plugin_messages.h

Issue 10965048: [BrowserTag] Send dib info with NavigateGuest message, (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Address comments from Fady + remove commented code. Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/common/browser_plugin_messages.h
diff --git a/content/common/browser_plugin_messages.h b/content/common/browser_plugin_messages.h
index f052b70135eac1d4fe3ca92ecf243a6fd680d1de..aafa82a0be1f160dd9d93882df0a81d52cf9de6d 100644
--- a/content/common/browser_plugin_messages.h
+++ b/content/common/browser_plugin_messages.h
@@ -57,17 +57,6 @@ IPC_MESSAGE_ROUTED3(BrowserPluginHostMsg_UpdateRect_ACK,
int /* message_id */,
gfx::Size /* repaint_view_size */)
-// A BrowserPlugin sends this to the browser process when it wants to navigate
-// to a given src URL. If a guest WebContents already exists, it will navigate
-// that WebContents. If not, it will create the WebContents, associate it with
-// the BrowserPlugin's browser-side BrowserPluginHost as a guest, and navigate
-// it to the requested URL.
-IPC_MESSAGE_ROUTED4(BrowserPluginHostMsg_NavigateGuest,
- int /* instance_id*/,
- int64 /* frame_id */,
- std::string /* src */,
- gfx::Size /* size */)
-
// When a BrowserPlugin has been removed from the embedder's DOM, it informs
// the browser process to cleanup the guest.
IPC_MESSAGE_ROUTED1(BrowserPluginHostMsg_PluginDestroyed,
@@ -96,6 +85,17 @@ IPC_STRUCT_BEGIN(BrowserPluginHostMsg_ResizeGuest_Params)
IPC_STRUCT_MEMBER(float, scale_factor)
IPC_STRUCT_END()
+// A BrowserPlugin sends this to BrowserPluginEmbedder (browser process) when it
+// wants to navigate to a given src URL. If a guest WebContents already exists,
+// it will navigate that WebContents. If not, it will create the WebContents,
+// associate it with the BrowserPluginGuest, and navigate it to the requested
+// URL.
+IPC_MESSAGE_ROUTED4(BrowserPluginHostMsg_NavigateGuest,
Charlie Reis 2012/09/25 22:44:24 Isn't this sent from the embedder's renderer proce
lazyboy 2012/09/25 23:15:30 Reverted moving. I needed this after the ResizeGue
+ int /* instance_id*/,
+ int64 /* frame_id */,
+ std::string /* src */,
+ BrowserPluginHostMsg_ResizeGuest_Params /* resize_params */)
+
// A embedder sends this message to the browser when it wants
// to resize a guest plugin container so that the guest is relaid out
// according to the new size.

Powered by Google App Engine
This is Rietveld 408576698