Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(144)

Unified Diff: chrome/browser/ui/panels/panel_host.cc

Issue 10965023: [Panels] Provide a tab id for web contents in Panels. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/panels/panel_host.cc
diff --git a/chrome/browser/ui/panels/panel_host.cc b/chrome/browser/ui/panels/panel_host.cc
index c78c12c0754bd6fcd55c106d97194b6fb55ce07f..5dd5ce44d9a15d6838a93e12f836f16f13bf3bcb 100644
--- a/chrome/browser/ui/panels/panel_host.cc
+++ b/chrome/browser/ui/panels/panel_host.cc
@@ -11,6 +11,7 @@
#include "chrome/browser/extensions/window_controller.h"
#include "chrome/browser/favicon/favicon_tab_helper.h"
#include "chrome/browser/profiles/profile.h"
+#include "chrome/browser/sessions/session_tab_helper.h"
#include "chrome/browser/ui/browser_navigator.h"
#include "chrome/browser/ui/panels/panel.h"
#include "chrome/browser/ui/prefs/prefs_tab_helper.h"
@@ -56,6 +57,11 @@ void PanelHost::Init(const GURL& url) {
web_contents_->SetDelegate(this);
content::WebContentsObserver::Observe(web_contents_.get());
+ // Needed to give the web contents a Tab ID.
Dmitry Titov 2012/09/21 01:29:42 Could you add a motivation to this comment, so it
jennb 2012/09/21 17:28:35 Done. http://crbug.com/151474 created to track the
+ SessionTabHelper::CreateForWebContents(web_contents_.get());
+ SessionTabHelper::FromWebContents(web_contents_.get())->SetWindowID(
+ panel_->session_id());
+
favicon_tab_helper_.reset(new FaviconTabHelper(web_contents_.get()));
prefs_tab_helper_.reset(new PrefsTabHelper(web_contents_.get()));

Powered by Google App Engine
This is Rietveld 408576698