[Panels] Provide a tab id for web contents in Panels.

chrome/browser/ui/panels/panel_host.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/panels/panel_host.h"
 
 #include "base/bind.h"
 #include "base/logging.h"
 #include "base/message_loop.h"
 #include "chrome/browser/chrome_page_zoom.h"
 #include "chrome/browser/extensions/window_controller.h"
 #include "chrome/browser/favicon/favicon_tab_helper.h"
 #include "chrome/browser/profiles/profile.h"
+#include "chrome/browser/sessions/session_tab_helper.h"
 #include "chrome/browser/ui/browser_navigator.h"
 #include "chrome/browser/ui/panels/panel.h"
 #include "chrome/browser/ui/prefs/prefs_tab_helper.h"
 #include "chrome/browser/ui/tab_contents/tab_contents.h"
 #include "chrome/browser/view_type_utils.h"
 #include "chrome/common/chrome_notification_types.h"
 #include "chrome/common/extensions/extension_messages.h"
 #include "content/public/browser/invalidate_type.h"
 #include "content/public/browser/navigation_controller.h"
 #include "content/public/browser/notification_service.h"
@@ skipping 25 matching lines @@
   if (url.is_empty())
     return;
 
   web_contents_.reset(content::WebContents::Create(
       profile_, content::SiteInstance::CreateForURL(profile_, url),
       MSG_ROUTING_NONE, NULL));
   chrome::SetViewType(web_contents_.get(), chrome::VIEW_TYPE_PANEL);
   web_contents_->SetDelegate(this);
   content::WebContentsObserver::Observe(web_contents_.get());
 
+  // Needed to give the web contents a Tab ID.

[Dmitry Titov, 2012/09/21 01:29:42]

Could you add a motivation to this comment, so it is clear that the only reason
we need the Tab ID here is to satisfy the extension tab API, partially. And I'd
add TODO to remove this in the future.

[jennb, 2012/09/21 17:28:35]

Done. http://crbug.com/151474 created to track the future cleanup.

+  SessionTabHelper::CreateForWebContents(web_contents_.get());
+  SessionTabHelper::FromWebContents(web_contents_.get())->SetWindowID(
+      panel_->session_id());
+
   favicon_tab_helper_.reset(new FaviconTabHelper(web_contents_.get()));
   prefs_tab_helper_.reset(new PrefsTabHelper(web_contents_.get()));
 
   web_contents_->GetController().LoadURL(
       url, content::Referrer(), content::PAGE_TRANSITION_LINK, std::string());
 }
 
 void PanelHost::DestroyWebContents() {
   favicon_tab_helper_.reset();
   prefs_tab_helper_.reset();
@@ skipping 177 matching lines @@
 }
 
 void PanelHost::StopLoading() {
   content::RecordAction(UserMetricsAction("Stop"));
   web_contents_->Stop();
 }
 
 void PanelHost::Zoom(content::PageZoom zoom) {
   chrome_page_zoom::Zoom(web_contents_.get(), zoom);
 }