[Panels] Provide a tab id for web contents in Panels.

[Panels] Provide a tab id for web contents in Panels.

TBR=mihaip
BUG=150830
TEST=ExtensionApiTest.MessagingPanel


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=158052

[Dmitry Titov, 2012-09-21 01:29:41]

lgtm with comments:

http://codereview.chromium.org/10965023/diff/1/chrome/browser/ui/panels/panel...
File chrome/browser/ui/panels/panel_host.cc (right):

http://codereview.chromium.org/10965023/diff/1/chrome/browser/ui/panels/panel...
chrome/browser/ui/panels/panel_host.cc:60: // Needed to give the web contents a
Tab ID.
Could you add a motivation to this comment, so it is clear that the only reason
we need the Tab ID here is to satisfy the extension tab API, partially. And I'd
add TODO to remove this in the future.

http://codereview.chromium.org/10965023/diff/1/chrome/test/data/extensions/ap...
File chrome/test/data/extensions/api_test/messaging/connect_panel/test.js
(right):

http://codereview.chromium.org/10965023/diff/1/chrome/test/data/extensions/ap...
chrome/test/data/extensions/api_test/messaging/connect_panel/test.js:4: var
panelWindowId = 0;
nit: add an empty line between license and this line.

[commit-bot: I haz the power, 2012-09-21 04:49:29]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jennb@chromium.org/10965023/1009

[jennb, 2012-09-21 17:28:35]

https://chromiumcodereview.appspot.com/10965023/diff/1/chrome/browser/ui/pane...
File chrome/browser/ui/panels/panel_host.cc (right):

https://chromiumcodereview.appspot.com/10965023/diff/1/chrome/browser/ui/pane...
chrome/browser/ui/panels/panel_host.cc:60: // Needed to give the web contents a
Tab ID.
On 2012/09/21 01:29:42, Dmitry Titov wrote:
> Could you add a motivation to this comment, so it is clear that the only
reason
> we need the Tab ID here is to satisfy the extension tab API, partially. And
I'd
> add TODO to remove this in the future.

Done. http://crbug.com/151474 created to track the future cleanup.

https://chromiumcodereview.appspot.com/10965023/diff/1/chrome/test/data/exten...
File chrome/test/data/extensions/api_test/messaging/connect_panel/test.js
(right):

https://chromiumcodereview.appspot.com/10965023/diff/1/chrome/test/data/exten...
chrome/test/data/extensions/api_test/messaging/connect_panel/test.js:4: var
panelWindowId = 0;
On 2012/09/21 01:29:42, Dmitry Titov wrote:
> nit: add an empty line between license and this line.

Done.

[commit-bot: I haz the power, 2012-09-21 17:46:40]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jennb@chromium.org/10965023/5003

[commit-bot: I haz the power, 2012-09-21 19:57:41]

Change committed as 158052