Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(250)

Issue 10963062: AudioHardwareUnifiedStream::Stop() must not clear |source_| before calling AudioDeviceStop(). (Closed)

Created:
8 years, 3 months ago by Chris Rogers
Modified:
8 years, 3 months ago
CC:
chromium-reviews, feature-media-reviews_chromium.org
Visibility:
Public.

Description

AudioHardwareUnifiedStream::Stop() must not clear |source_| before calling AudioDeviceStop(). BUG=151990 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=158489

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2 lines) Patch
M media/audio/mac/audio_unified_mac.cc View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Chris Rogers
8 years, 3 months ago (2012-09-24 19:10:15 UTC) #1
scherkus (not reviewing)
lgtm
8 years, 3 months ago (2012-09-24 19:50:25 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/crogers@google.com/10963062/1
8 years, 3 months ago (2012-09-24 19:51:04 UTC) #3
commit-bot: I haz the power
Retried try job too often for step(s) browser_tests
8 years, 3 months ago (2012-09-24 22:57:21 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/crogers@google.com/10963062/1
8 years, 3 months ago (2012-09-24 23:39:08 UTC) #5
commit-bot: I haz the power
8 years, 3 months ago (2012-09-25 01:25:50 UTC) #6
Change committed as 158489

Powered by Google App Engine
This is Rietveld 408576698