media/audio/mac/audio_unified_mac.cc - Issue 10963062: AudioHardwareUnifiedStream::Stop() must not clear |source_| before calling AudioDeviceStop().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: media/audio/mac/audio_unified_mac.cc

Issue 10963062: AudioHardwareUnifiedStream::Stop() must not clear |source_| before calling AudioDeviceStop(). (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/

Patch Set: Created 8 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: media/audio/mac/audio_unified_mac.cc

===================================================================

--- media/audio/mac/audio_unified_mac.cc (revision 158044)

+++ media/audio/mac/audio_unified_mac.cc (working copy)

@@ -278,14 +278,13 @@

if (!is_playing_)

return;

- source_ = NULL;

if (device_ != kAudioObjectUnknown) {

OSStatus result = AudioDeviceStop(device_, io_proc_id_);

OSSTATUS_DCHECK(result == noErr, result);

}

is_playing_ = false;

+ source_ = NULL;

}

void AudioHardwareUnifiedStream::SetVolume(double volume) {

« no previous file with comments | « no previous file | no next file » | no next file with comments »