Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(465)

Issue 10963061: Switch AutomationTabHelper to use WebContentsUserData. (Closed)

Created:
8 years, 3 months ago by Avi (use Gerrit)
Modified:
8 years, 2 months ago
CC:
chromium-reviews, robertshield, Avi (use Gerrit), kkania, creis+watch_chromium.org, ajwong+watch_chromium.org
Visibility:
Public.

Description

Switch AutomationTabHelper to use WebContentsUserData. BUG=107201 TEST=no visible change Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=158912

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -21 lines) Patch
M chrome/browser/automation/automation_provider_observers.cc View 2 chunks +10 lines, -6 lines 0 comments Download
M chrome/browser/automation/automation_tab_helper.h View 3 chunks +7 lines, -2 lines 0 comments Download
M chrome/browser/automation/automation_tab_helper.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/automation/automation_tab_helper_browsertest.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/automation/automation_tab_helper_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/automation/testing_automation_provider.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M chrome/browser/ui/tab_contents/tab_contents.h View 1 3 chunks +0 lines, -7 lines 0 comments Download
M chrome/browser/ui/tab_contents/tab_contents.cc View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (0 generated)
Avi (use Gerrit)
8 years, 2 months ago (2012-09-25 19:35:20 UTC) #1
Ben Goodger (Google)
lgtm
8 years, 2 months ago (2012-09-26 17:38:51 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/avi@chromium.org/10963061/4001
8 years, 2 months ago (2012-09-26 18:04:01 UTC) #3
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build. Your ...
8 years, 2 months ago (2012-09-26 18:20:46 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/avi@chromium.org/10963061/4001
8 years, 2 months ago (2012-09-26 18:26:04 UTC) #5
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build. Your ...
8 years, 2 months ago (2012-09-26 18:34:42 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/avi@chromium.org/10963061/4001
8 years, 2 months ago (2012-09-26 19:03:05 UTC) #7
commit-bot: I haz the power
8 years, 2 months ago (2012-09-26 22:43:26 UTC) #8
Change committed as 158912

Powered by Google App Engine
This is Rietveld 408576698