Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(116)

Issue 10962023: Prefix Chrome switches with the switch prefix. (Closed)

Created:
8 years, 3 months ago by grt (UTC plus 2)
Modified:
8 years, 2 months ago
Reviewers:
cpu_(ooo_6.6-7.5)
CC:
chromium-reviews, robertshield
Visibility:
Public.

Description

Prefix Chrome switches with the switch prefix. Use CommandLine throughout rather than diddling with strings. Use ScopedProcessInformation when calling CreateProcess. BUG=151452 TEST=relaunch chrome via about:flags and hope not to see a tab navigated to "force-desktop". also, hope that relaunching between desktop and metro works. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=159364

Patch Set 1 : #

Total comments: 1

Patch Set 2 : #

Total comments: 2

Patch Set 3 : ToT #

Unified diffs Side-by-side diffs Delta from patch set Stats (+215 lines, -44 lines) Patch
M win8/delegate_execute/command_execute_impl.h View 1 2 chunks +2 lines, -1 line 0 comments Download
M win8/delegate_execute/command_execute_impl.cc View 1 2 5 chunks +19 lines, -29 lines 0 comments Download
M win8/delegate_execute/delegate_execute.cc View 1 2 chunks +2 lines, -3 lines 0 comments Download
M win8/delegate_execute/delegate_execute.gyp View 1 2 chunks +23 lines, -5 lines 0 comments Download
M win8/delegate_execute/delegate_execute_operation.h View 2 chunks +2 lines, -2 lines 0 comments Download
M win8/delegate_execute/delegate_execute_operation.cc View 1 2 chunks +8 lines, -4 lines 0 comments Download
A win8/delegate_execute/delegate_execute_util.h View 1 1 chunk +30 lines, -0 lines 0 comments Download
A win8/delegate_execute/delegate_execute_util.cc View 1 1 chunk +50 lines, -0 lines 0 comments Download
A win8/delegate_execute/delegate_execute_util_unittest.cc View 1 1 chunk +79 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
grt (UTC plus 2)
Whaddya think?
8 years, 3 months ago (2012-09-21 03:47:16 UTC) #1
cpu_(ooo_6.6-7.5)
I remember doing the -- prefix and having issues in the other side of delegate ...
8 years, 3 months ago (2012-09-21 19:28:01 UTC) #2
grt (UTC plus 2)
On 2012/09/21 19:28:01, cpu wrote: > I remember doing the -- prefix and having issues ...
8 years, 3 months ago (2012-09-24 17:40:11 UTC) #3
cpu_(ooo_6.6-7.5)
oh man nice cleanup. Give me one more day to look it over. i've been ...
8 years, 2 months ago (2012-09-26 18:32:00 UTC) #4
grt (UTC plus 2)
On 2012/09/26 18:32:00, cpu wrote: > oh man nice cleanup. Give me one more day ...
8 years, 2 months ago (2012-09-26 18:46:43 UTC) #5
cpu_(ooo_6.6-7.5)
lgtm https://codereview.chromium.org/10962023/diff/8022/win8/delegate_execute/delegate_execute_util.cc File win8/delegate_execute/delegate_execute_util.cc (right): https://codereview.chromium.org/10962023/diff/8022/win8/delegate_execute/delegate_execute_util.cc#newcode15 win8/delegate_execute/delegate_execute_util.cc:15: if (params) { is it valid to pass ...
8 years, 2 months ago (2012-09-28 20:03:13 UTC) #6
grt (UTC plus 2)
thanks https://chromiumcodereview.appspot.com/10962023/diff/8022/win8/delegate_execute/delegate_execute_util.cc File win8/delegate_execute/delegate_execute_util.cc (right): https://chromiumcodereview.appspot.com/10962023/diff/8022/win8/delegate_execute/delegate_execute_util.cc#newcode15 win8/delegate_execute/delegate_execute_util.cc:15: if (params) { On 2012/09/28 20:03:13, cpu wrote: ...
8 years, 2 months ago (2012-09-28 20:11:23 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/grt@chromium.org/10962023/8022
8 years, 2 months ago (2012-09-28 20:11:58 UTC) #8
commit-bot: I haz the power
Failed to apply patch for win8/delegate_execute/command_execute_impl.cc: While running patch -p1 --forward --force; patching file win8/delegate_execute/command_execute_impl.cc ...
8 years, 2 months ago (2012-09-28 20:12:00 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/grt@chromium.org/10962023/16002
8 years, 2 months ago (2012-09-28 20:29:35 UTC) #10
commit-bot: I haz the power
8 years, 2 months ago (2012-09-28 23:42:25 UTC) #11
Change committed as 159364

Powered by Google App Engine
This is Rietveld 408576698