Prefix Chrome switches with the switch prefix.

Prefix Chrome switches with the switch prefix.

Use CommandLine throughout rather than diddling with strings.
Use ScopedProcessInformation when calling CreateProcess.

BUG=151452
TEST=relaunch chrome via about:flags and hope not to see a tab navigated to "force-desktop".  also, hope that relaunching between desktop and metro works.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=159364

[grt (UTC plus 2), 2012-09-21 03:47:16]

Whaddya think?

[cpu_(ooo_6.6-7.5), 2012-09-21 19:28:01]

I remember doing the -- prefix and having issues in the other side of delegate
execute (the non-relaunch path) because of how we manipulate strings. Is it
working in the relaunch from metro?

Also that switch command line is meaningless for chrome, can we not give it to
chrome?

http://codereview.chromium.org/10962023/diff/3001/win8/delegate_execute/deleg...
File win8/delegate_execute/delegate_execute.cc (right):

http://codereview.chromium.org/10962023/diff/3001/win8/delegate_execute/deleg...
win8/delegate_execute/delegate_execute.cc:91: sei.lpParameters =
operation.relaunch_flags().c_str();
this is fine but note that my version is defensive because if you change the
interface fro:

string16& relaunch_flags() const { }
to
string16 relaunch_flags() const { }

Then everything works except here you take a pointer to the internal string a
temporary std::string (!!). We had this kind of bugs.

[grt (UTC plus 2), 2012-09-24 17:40:11]

On 2012/09/21 19:28:01, cpu wrote:
> I remember doing the -- prefix and having issues in the other side of delegate
> execute (the non-relaunch path) because of how we manipulate strings. Is it
> working in the relaunch from metro?

Oh, yeah, that.  No, it didn't work before.  It does now.  Please take another
look (I've taken the opportunity to introduce a unit test that at least covers
some of the basics).

[cpu_(ooo_6.6-7.5), 2012-09-26 18:32:00]

oh man nice cleanup. Give me one more day to look it over. i've been sick and
now perf is due.

[grt (UTC plus 2), 2012-09-26 18:46:43]

On 2012/09/26 18:32:00, cpu wrote:
> oh man nice cleanup. Give me one more day to look it over. i've been sick and
> now perf is due.

np.  when you get back to it, have a read through my last comment on
http://crbug.com/152075.  this change should fix that issue too, although i
think there's a race that may or may not be a problem.

[cpu_(ooo_6.6-7.5), 2012-09-28 20:03:13]

lgtm

https://codereview.chromium.org/10962023/diff/8022/win8/delegate_execute/dele...
File win8/delegate_execute/delegate_execute_util.cc (right):

https://codereview.chromium.org/10962023/diff/8022/win8/delegate_execute/dele...
win8/delegate_execute/delegate_execute_util.cc:15: if (params) {
is it valid to pass no params? or rather just CHECK here?

[grt (UTC plus 2), 2012-09-28 20:11:23]

thanks

https://chromiumcodereview.appspot.com/10962023/diff/8022/win8/delegate_execu...
File win8/delegate_execute/delegate_execute_util.cc (right):

https://chromiumcodereview.appspot.com/10962023/diff/8022/win8/delegate_execu...
win8/delegate_execute/delegate_execute_util.cc:15: if (params) {
On 2012/09/28 20:03:13, cpu wrote:
> is it valid to pass no params? or rather just CHECK here?

i'm not sure if the shell will ever call CommandExecuteImpl::SetParameters with
NULL.  the previous code in SetParameters handled NULL similarly to this code. 
i don't see any harm in handling it this way.

[commit-bot: I haz the power, 2012-09-28 20:11:58]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/grt@chromium.org/10962023/8022

[commit-bot: I haz the power, 2012-09-28 20:12:00]

Failed to apply patch for win8/delegate_execute/command_execute_impl.cc:
While running patch -p1 --forward --force;
patching file win8/delegate_execute/command_execute_impl.cc
Hunk #1 FAILED at 13.
Hunk #2 succeeded at 76 (offset 1 line).
Hunk #3 succeeded at 95 (offset 1 line).
Hunk #4 succeeded at 351 (offset 2 lines).
Hunk #5 succeeded at 390 (offset 2 lines).
1 out of 5 hunks FAILED -- saving rejects to file
win8/delegate_execute/command_execute_impl.cc.rej

[commit-bot: I haz the power, 2012-09-28 20:29:35]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/grt@chromium.org/10962023/16002

[commit-bot: I haz the power, 2012-09-28 23:42:25]

Change committed as 159364