Issue 10961051: Switch PluginObserver to use WebContentsUserData.

Issue 10961051: Switch PluginObserver to use WebContentsUserData. (Closed)

Created:
8 years, 3 months ago by Avi (use Gerrit)

Modified:
8 years, 3 months ago

Reviewers:
Bernhard Bauer

CC:
chromium-reviews, Avi (use Gerrit), creis+watch_chromium.org, jam, darin-cc_chromium.org, ajwong+watch_chromium.org, stuartmorgan+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Switch PluginObserver to use WebContentsUserData. BUG=107201 TEST=no visible change Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=158307

Patch Set 2 : commentary #

Created: 8 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+42 lines, -29 lines)			Patch
M	chrome/browser/plugins/plugin_infobar_delegates.cc	View	1	2 chunks	+4 lines, -2 lines	0 comments	Download
M	chrome/browser/plugins/plugin_observer.h	View	1	4 chunks	+13 lines, -6 lines	0 comments	Download
M	chrome/browser/plugins/plugin_observer.cc	View		11 chunks	+24 lines, -18 lines	0 comments	Download
M	chrome/browser/ui/tab_contents/tab_contents.h	View	1	2 chunks	+0 lines, -2 lines	0 comments	Download
M	chrome/browser/ui/tab_contents/tab_contents.cc	View	1	2 chunks	+1 line, -1 line	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Bernhard Bauer

LGTM w/ nits and one suggestion: https://codereview.chromium.org/10961051/diff/1/chrome/browser/plugins/plugin_observer.h File chrome/browser/plugins/plugin_observer.h (right): https://codereview.chromium.org/10961051/diff/1/chrome/browser/plugins/plugin_observer.h#newcode42 chrome/browser/plugins/plugin_observer.h:42: using content::WebContentsObserver::web_contents; Nit: ...

8 years, 3 months ago (2012-09-24 08:55:18 UTC) #2

Avi (use Gerrit)

https://codereview.chromium.org/10961051/diff/1/chrome/browser/plugins/plugin_observer.h File chrome/browser/plugins/plugin_observer.h (right): https://codereview.chromium.org/10961051/diff/1/chrome/browser/plugins/plugin_observer.h#newcode42 chrome/browser/plugins/plugin_observer.h:42: using content::WebContentsObserver::web_contents; I'm killing TabContents (see the referenced bug) ...

8 years, 3 months ago (2012-09-24 15:27:50 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/avi@chromium.org/10961051/6001

8 years, 3 months ago (2012-09-24 15:29:09 UTC) #4

Change committed as 158307

Expand Messages | Collapse Messages