Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(850)

Issue 10960010: Speech Input: always abort when user clicks outside speech bubble. (Closed)

Created:
8 years, 3 months ago by hans
Modified:
8 years, 3 months ago
Reviewers:
Satish
CC:
chromium-reviews, Satish
Visibility:
Public.

Description

Speech Input: always abort when user clicks outside speech bubble. This prevents a race which would lead to a browser crash (null ptr deref) when a speech input icon is clicked on repeatedly: 1. User clicks speech icon 2. We show speech bubble, ask sound system to start recording 3. User clicks outside bubble, we close it 3a. Speech system not recording yet, so we don't abort session 4. Sound system calls back: "Here's some audio!" 5. We try to update the bubble which dosn't exist anymore. This patch fixes 3a; we should just always abort here. BUG=146689 TEST=manual (click speech icon rapidly many times) Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=157777

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -5 lines) Patch
M chrome/browser/speech/chrome_speech_recognition_manager_delegate.cc View 1 chunk +2 lines, -5 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
hans
8 years, 3 months ago (2012-09-20 11:41:59 UTC) #1
Satish
lgtm
8 years, 3 months ago (2012-09-20 12:37:10 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hans@chromium.org/10960010/1
8 years, 3 months ago (2012-09-20 12:41:59 UTC) #3
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build. Your ...
8 years, 3 months ago (2012-09-20 14:38:11 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hans@chromium.org/10960010/1
8 years, 3 months ago (2012-09-20 14:42:35 UTC) #5
commit-bot: I haz the power
8 years, 3 months ago (2012-09-20 15:56:23 UTC) #6
Change committed as 157777

Powered by Google App Engine
This is Rietveld 408576698