Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(753)

Issue 10956062: Disable jobs sent directly to triggered bots (Closed)

Created:
8 years, 3 months ago by Isaac (away)
Modified:
8 years, 3 months ago
Reviewers:
cmp, M-A Ruel
CC:
chromium-reviews
Base URL:
https://git.chromium.org/chromium/tools/depot_tools.git@master
Visibility:
Public.

Description

Disable jobs sent directly to triggered bots - and display a warning message BUG=146713 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=158377

Patch Set 1 #

Total comments: 5

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -0 lines) Patch
M git_cl.py View 1 1 chunk +8 lines, -0 lines 0 comments Download
M trychange.py View 1 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Isaac (away)
Please take a look at wording. Just want something concise; a couple people have asked ...
8 years, 3 months ago (2012-09-24 04:12:41 UTC) #1
M-A Ruel
lgtm https://chromiumcodereview.appspot.com/10956062/diff/1/git_cl.py File git_cl.py (right): https://chromiumcodereview.appspot.com/10956062/diff/1/git_cl.py#newcode1594 git_cl.py:1594: if any('triggered' in b for b in builders_and_tests.iterkeys()): ...
8 years, 3 months ago (2012-09-24 13:48:00 UTC) #2
Isaac (away)
https://chromiumcodereview.appspot.com/10956062/diff/1/trychange.py File trychange.py (right): https://chromiumcodereview.appspot.com/10956062/diff/1/trychange.py#newcode839 trychange.py:839: if any('triggered' in b.split(':')[0] for b in options.bot): On ...
8 years, 3 months ago (2012-09-24 17:53:02 UTC) #3
Isaac (away)
https://chromiumcodereview.appspot.com/10956062/diff/1/git_cl.py File git_cl.py (right): https://chromiumcodereview.appspot.com/10956062/diff/1/git_cl.py#newcode1594 git_cl.py:1594: if any('triggered' in b for b in builders_and_tests.iterkeys()): On ...
8 years, 3 months ago (2012-09-24 20:45:07 UTC) #4
Isaac (away)
I'm going to commit as is and we can revise the language later if it ...
8 years, 3 months ago (2012-09-24 20:45:38 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ilevy@chromium.org/10956062/5001
8 years, 3 months ago (2012-09-24 20:46:03 UTC) #6
commit-bot: I haz the power
8 years, 3 months ago (2012-09-24 20:48:56 UTC) #7
Change committed as 158377

Powered by Google App Engine
This is Rietveld 408576698