Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Unified Diff: trychange.py

Issue 10956062: Disable jobs sent directly to triggered bots (Closed) Base URL: https://git.chromium.org/chromium/tools/depot_tools.git@master
Patch Set: Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « git_cl.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: trychange.py
diff --git a/trychange.py b/trychange.py
index 39b827b10bde6d11291562a828494e5c99e172ab..73c81ee543f482f0723bdb5662540e9a0362d839 100755
--- a/trychange.py
+++ b/trychange.py
@@ -836,6 +836,13 @@ def TryChange(argv,
# If no bot is specified, either the default pool will be selected or the
# try server will refuse the job. Either case we don't need to interfere.
+ if any('triggered' in b.split(':', 1)[0] for b in options.bot):
+ print >> sys.stderr, (
+ 'ERROR You are trying to send a job to a triggered bot. This type of'
+ ' bot requires an\ninitial job from a parent (usually a builder). '
+ 'Instead send your job to the parent.\nBot list: %s' % options.bot)
+ return 1
+
if options.print_bots:
print 'Bots which would be used:'
for bot in options.bot:
« no previous file with comments | « git_cl.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698