Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1197)

Issue 10956047: make pylint behave the same with or without -v (Closed)

Created:
8 years, 3 months ago by Sam Clegg
Modified:
8 years, 3 months ago
Reviewers:
M-A Ruel
CC:
chromium-reviews
Base URL:
https://git.chromium.org/chromium/tools/depot_tools.git@master
Visibility:
Public.

Description

make pylint behave the same with or without -v BUG=http://code.google.com/p/chromium/issues/detail?id=151110 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=158064

Patch Set 1 #

Total comments: 1

Patch Set 2 : fix nits #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -1 line) Patch
M presubmit_canned_checks.py View 1 1 chunk +6 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
M-A Ruel
lgtm with True instead. http://codereview.chromium.org/10956047/diff/1/presubmit_canned_checks.py File presubmit_canned_checks.py (right): http://codereview.chromium.org/10956047/diff/1/presubmit_canned_checks.py#newcode683 presubmit_canned_checks.py:683: if 1: if True:
8 years, 3 months ago (2012-09-21 20:08:07 UTC) #1
Sam Clegg
8 years, 3 months ago (2012-09-21 20:09:29 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sbc@chromium.org/10956047/4001
8 years, 3 months ago (2012-09-21 20:11:26 UTC) #3
commit-bot: I haz the power
8 years, 3 months ago (2012-09-21 20:14:23 UTC) #4
Change committed as 158064

Powered by Google App Engine
This is Rietveld 408576698