Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(299)

Unified Diff: presubmit_canned_checks.py

Issue 10956047: make pylint behave the same with or without -v (Closed) Base URL: https://git.chromium.org/chromium/tools/depot_tools.git@master
Patch Set: fix nits Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: presubmit_canned_checks.py
diff --git a/presubmit_canned_checks.py b/presubmit_canned_checks.py
index 046424bef4dae723ffe34954109118e6a3679cd3..e55c92c06b1bcfa832826bbb0e0f999423665d9f 100644
--- a/presubmit_canned_checks.py
+++ b/presubmit_canned_checks.py
@@ -675,7 +675,12 @@ def RunPylint(input_api, output_api, white_list=None, black_list=None,
return 'Pylint failed!'
result = None
- if not input_api.verbose:
+ # Always run pylint and pass it all the py files at once.
+ # Passing py files one at time is slower and can produce
+ # different results. input_api.verbose used to be used
+ # to enable this behaviour but differing behaviour in
+ # verbose mode is not desirable.
+ if True:
result = run_lint(sorted(files))
else:
for filename in sorted(files):
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698