Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1129)

Issue 10956006: Convert CC scheduler logic to use base::TimeTicks/Delta instead of doubles (Closed)

Created:
8 years, 3 months ago by jamesr
Modified:
8 years, 3 months ago
Reviewers:
nduca
CC:
chromium-reviews, cc-bugs_chromium.org
Visibility:
Public.

Description

Convert CC scheduler logic to use base::TimeTicks/Delta instead of doubles Instead of using double seconds, this converts the scheduler and timer logic in libcc to use base::TimeTicks and base::TimeDelta. This puts the units in the type system instead of variable names and comments making second/millisecond confusion less likely and integrates better with the rest of chromium. BUG= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=157783

Patch Set 1 #

Patch Set 2 : rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+159 lines, -162 lines) Patch
M cc/CCDelayBasedTimeSource.h View 2 chunks +12 lines, -12 lines 0 comments Download
M cc/CCDelayBasedTimeSource.cpp View 8 chunks +31 lines, -34 lines 0 comments Download
M cc/CCDelayBasedTimeSourceTest.cpp View 26 chunks +45 lines, -51 lines 0 comments Download
M cc/CCFrameRateController.h View 2 chunks +3 lines, -3 lines 0 comments Download
M cc/CCFrameRateController.cpp View 2 chunks +4 lines, -4 lines 0 comments Download
M cc/CCFrameRateControllerTest.cpp View 5 chunks +24 lines, -22 lines 0 comments Download
M cc/CCLayerTreeHostImpl.h View 1 2 chunks +3 lines, -2 lines 0 comments Download
M cc/CCLayerTreeHostImpl.cpp View 1 1 chunk +2 lines, -2 lines 0 comments Download
M cc/CCScheduler.h View 3 chunks +3 lines, -3 lines 0 comments Download
M cc/CCScheduler.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M cc/CCSchedulerTest.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M cc/CCThreadProxy.h View 1 chunk +1 line, -1 line 0 comments Download
M cc/CCThreadProxy.cpp View 1 3 chunks +7 lines, -5 lines 0 comments Download
M cc/CCThreadedTest.h View 1 chunk +1 line, -1 line 0 comments Download
M cc/CCThreadedTest.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M cc/CCTimeSource.h View 2 chunks +4 lines, -3 lines 0 comments Download
M cc/test/CCSchedulerTestCommon.h View 3 chunks +12 lines, -12 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
jamesr
8 years, 3 months ago (2012-09-20 03:36:43 UTC) #1
nduca
lgtm
8 years, 3 months ago (2012-09-20 03:52:52 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jamesr@chromium.org/10956006/4001
8 years, 3 months ago (2012-09-20 05:30:19 UTC) #3
commit-bot: I haz the power
8 years, 3 months ago (2012-09-20 16:33:50 UTC) #4
Change committed as 157783

Powered by Google App Engine
This is Rietveld 408576698