Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(84)

Issue 10952021: Moving preference API into api/preferences (Closed)

Created:
8 years, 3 months ago by vabr (Chromium)
Modified:
8 years, 3 months ago
Reviewers:
Yoyo Zhou
CC:
chromium-reviews, Aaron Boodman, mihaip-chromium-reviews_chromium.org
Visibility:
Public.

Description

Moving preference API into api/preferences Also putting it into extensions namespace and removing redundant "extension" prefixes from names. BUG=101244 TEST=N/A, no code change, moving stuff around only TBR=ben@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=157600

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+87 lines, -1158 lines) Patch
M chrome/browser/extensions/api/content_settings/content_settings_api.cc View 2 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/extensions/api/font_settings/font_settings_api.cc View 5 chunks +11 lines, -11 lines 0 comments Download
M chrome/browser/extensions/api/managed_mode/managed_mode_api.cc View 3 chunks +4 lines, -3 lines 0 comments Download
A + chrome/browser/extensions/api/preference/preference_api.h View 4 chunks +11 lines, -7 lines 0 comments Download
A + chrome/browser/extensions/api/preference/preference_api.cc View 7 chunks +14 lines, -13 lines 0 comments Download
A + chrome/browser/extensions/api/preference/preference_api_constants.h View 2 chunks +7 lines, -5 lines 0 comments Download
A + chrome/browser/extensions/api/preference/preference_api_constants.cc View 2 chunks +5 lines, -3 lines 0 comments Download
A + chrome/browser/extensions/api/preference/preference_apitest.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/browser/extensions/api/preference/preference_helpers.h View 3 chunks +7 lines, -5 lines 0 comments Download
A + chrome/browser/extensions/api/preference/preference_helpers.cc View 4 chunks +6 lines, -4 lines 0 comments Download
M chrome/browser/extensions/api/proxy/proxy_api.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/extension_function_registry.cc View 3 chunks +4 lines, -4 lines 0 comments Download
D chrome/browser/extensions/extension_preference_api.h View 1 chunk +0 lines, -118 lines 0 comments Download
D chrome/browser/extensions/extension_preference_api.cc View 1 chunk +0 lines, -493 lines 0 comments Download
D chrome/browser/extensions/extension_preference_api_constants.h View 1 chunk +0 lines, -26 lines 0 comments Download
D chrome/browser/extensions/extension_preference_api_constants.cc View 1 chunk +0 lines, -28 lines 0 comments Download
D chrome/browser/extensions/extension_preference_apitest.cc View 1 chunk +0 lines, -239 lines 0 comments Download
D chrome/browser/extensions/extension_preference_helpers.h View 1 chunk +0 lines, -47 lines 0 comments Download
D chrome/browser/extensions/extension_preference_helpers.cc View 1 chunk +0 lines, -135 lines 0 comments Download
M chrome/browser/extensions/extension_service.h View 3 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/extension_service.cc View 3 chunks +3 lines, -2 lines 0 comments Download
M chrome/chrome_browser_extensions.gypi View 2 chunks +6 lines, -6 lines 0 comments Download
M chrome/chrome_tests.gypi View 2 chunks +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
vabr (Chromium)
Hi Yoyo, Could you please take a look at this? Thanks, Vaclav
8 years, 3 months ago (2012-09-19 11:03:42 UTC) #1
Yoyo Zhou
LGTM By the way, the TEST= line is for instructions to the QA team, so ...
8 years, 3 months ago (2012-09-19 17:58:33 UTC) #2
vabr (Chromium)
Thanks Yoyo, I tend to put the TEST=N/A there in case the QA people wonder ...
8 years, 3 months ago (2012-09-19 18:19:34 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vabr@chromium.org/10952021/1
8 years, 3 months ago (2012-09-19 18:19:50 UTC) #4
commit-bot: I haz the power
8 years, 3 months ago (2012-09-19 20:36:55 UTC) #5
Change committed as 157600

Powered by Google App Engine
This is Rietveld 408576698