Issue 10951015: Issue 5152: Browser bots much more flaky after going "wrapperless"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10951015: Issue 5152: Browser bots much more flaky after going "wrapperless" (Closed)

Created:
8 years, 3 months ago by gram

Modified:
8 years, 3 months ago

Reviewers:
ahe, Emily Fortuna

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Issue 5152: Browser bots much more flaky after going "wrapperless" Committed: https://code.google.com/p/dart/source/detail?r=12515

Patch Set 2 : #

Total comments: 2

Created: 8 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+18 lines, -1 line)			Patch
M	pkg/unittest/html_config.dart	View	2 chunks	+8 lines, -0 lines	0 comments	Download
M	pkg/unittest/html_enhanced_config.dart	View	3 chunks	+8 lines, -0 lines	0 comments	Download
M	pkg/unittest/test_controller.js	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	tests/html/html.status	View	1 chunk	+1 line, -1 line	2 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

gram

Added a message listener in the config classes to listen for failures from the js ...

8 years, 3 months ago (2012-09-18 20:55:39 UTC) #1

Emily Fortuna

https://chromiumcodereview.appspot.com/10951015/diff/2001/tests/html/html.status File tests/html/html.status (right): https://chromiumcodereview.appspot.com/10951015/diff/2001/tests/html/html.status#newcode5 tests/html/html.status:5: #window_open_test: Fail, Pass # http://dartbug.com/5151 can we make this ...

8 years, 3 months ago (2012-09-18 20:59:17 UTC) #2