Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(551)

Unified Diff: lib/coreimpl/exceptions.dart

Issue 10950006: Convert most interfaces in dart:core to abstract classes. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: lib/coreimpl/exceptions.dart
diff --git a/lib/coreimpl/exceptions.dart b/lib/coreimpl/exceptions.dart
index c2dd3a2f4df3754d168a340d568f1eee2b9ee756..72559ba6e231a91abf191d6fb948706c4db13b1b 100644
--- a/lib/coreimpl/exceptions.dart
+++ b/lib/coreimpl/exceptions.dart
@@ -3,7 +3,7 @@
// BSD-style license that can be found in the LICENSE file.
class ExceptionImplementation implements Exception {
- const ExceptionImplementation([msg = null]) : _msg = msg;
- String toString() => (_msg === null) ? "Exception" : "Exception: $_msg";
- final _msg;
+ final message;
ahe 2012/09/18 12:30:56 Move to public API?
Lasse Reichstein Nielsen 2012/09/18 12:39:42 Eventually, yes.
+ const ExceptionImplementation([this.message]);
+ String toString() => (message == null) ? "Exception" : "Exception: $message";
ahe 2012/09/18 12:30:56 FYI, I like this general approach to toString: 'C
Lasse Reichstein Nielsen 2012/09/18 12:39:42 The problem with "throwables" is that their toStri
}

Powered by Google App Engine
This is Rietveld 408576698