lib/coreimpl/exceptions.dart - Issue 10950006: Convert most interfaces in dart:core to abstract classes.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: lib/coreimpl/exceptions.dart

Issue 10950006: Convert most interfaces in dart:core to abstract classes. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 8 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

OLD	NEW
1 // Copyright (c) 2011, the Dart project authors. Please see the AUTHORS file	1 // Copyright (c) 2011, the Dart project authors. Please see the AUTHORS file

2 // for details. All rights reserved. Use of this source code is governed by a	2 // for details. All rights reserved. Use of this source code is governed by a

3 // BSD-style license that can be found in the LICENSE file.	3 // BSD-style license that can be found in the LICENSE file.

4	4

5 class ExceptionImplementation implements Exception {	5 class ExceptionImplementation implements Exception {

6 const ExceptionImplementation([msg = null]) : _msg = msg;	6 final message;
	ahe 2012/09/18 12:30:56 Move to public API? Move to public API? Lasse Reichstein Nielsen 2012/09/18 12:39:42 Eventually, yes. Eventually, yes.
7 String toString() => (_msg === null) ? "Exception" : "Exception: $_msg";	7 const ExceptionImplementation([this.message]);

8 final _msg;	8 String toString() => (message == null) ? "Exception" : "Exception: $message";
	ahe 2012/09/18 12:30:56 FYI, I like this general approach to toString: 'C FYI, I like this general approach to toString: 'ClassName($field1, $field2, ...)' Lasse Reichstein Nielsen 2012/09/18 12:39:42 The problem with "throwables" is that their toStri The problem with "throwables" is that their toString is used to print uncaught exceptions, and they should be readable.
9 }	9 }

OLD	NEW

« lib/coreimpl/date.dart ('K') | « lib/coreimpl/duration_implementation.dart ('k') | lib/coreimpl/string_buffer.dart » ('j') | no next file with comments »