Turn definitions that do not produce results (e.g. Checks) into instructions.

Turn definitions that do not produce results (e.g. Checks) into instructions.

This allows more uniform iteration of IR for example when we are looking for all Smi values.

R=fschneider@google.com
BUG=

Committed: https://code.google.com/p/dart/source/detail?r=12563

[Florian Schneider, 2012-09-19 13:24:49]

lgtm

https://codereview.chromium.org/10949019/diff/1/runtime/vm/flow_graph_optimiz...
File runtime/vm/flow_graph_optimizer.cc (right):

https://codereview.chromium.org/10949019/diff/1/runtime/vm/flow_graph_optimiz...
runtime/vm/flow_graph_optimizer.cc:38: if (replacement != current) {
Maybe assert that Canonicalize for Instructions returns either NULL or this.

https://codereview.chromium.org/10949019/diff/1/runtime/vm/flow_graph_optimiz...
runtime/vm/flow_graph_optimizer.cc:1775: }
Maybe add the same debug output as in the Canonicalize-pass:

OS::Print("Removing %s\n", current->DebugName());

https://codereview.chromium.org/10949019/diff/1/runtime/vm/intermediate_langu...
File runtime/vm/intermediate_language.cc (right):

https://codereview.chromium.org/10949019/diff/1/runtime/vm/intermediate_langu...
runtime/vm/intermediate_language.cc:1209: Definition* Definition::Canonicalize()
{
Definition::Canonicalize not needed anymore?

[Vyacheslav Egorov (Google), 2012-09-21 12:51:40]

publishing old drafts

https://chromiumcodereview.appspot.com/10949019/diff/1/runtime/vm/flow_graph_...
File runtime/vm/flow_graph_optimizer.cc (right):

https://chromiumcodereview.appspot.com/10949019/diff/1/runtime/vm/flow_graph_...
runtime/vm/flow_graph_optimizer.cc:38: if (replacement != current) {
On 2012/09/19 13:24:49, Florian Schneider wrote:
> Maybe assert that Canonicalize for Instructions returns either NULL or this.

Done.

https://chromiumcodereview.appspot.com/10949019/diff/1/runtime/vm/flow_graph_...
runtime/vm/flow_graph_optimizer.cc:1775: }
On 2012/09/19 13:24:49, Florian Schneider wrote:
> Maybe add the same debug output as in the Canonicalize-pass:
> 
> OS::Print("Removing %s\n", current->DebugName());

Done.

https://chromiumcodereview.appspot.com/10949019/diff/1/runtime/vm/intermediat...
File runtime/vm/intermediate_language.cc (right):

https://chromiumcodereview.appspot.com/10949019/diff/1/runtime/vm/intermediat...
runtime/vm/intermediate_language.cc:1209: Definition* Definition::Canonicalize()
{
On 2012/09/19 13:24:49, Florian Schneider wrote:
> Definition::Canonicalize not needed anymore?

It is needed to make the code more typesafe to guarantee that all subclasses of
Definition return Definition* as a result of canonicalization.