Chromium Code Reviews Chromium Code Reviews
Issue
10949005:
Fix toolbar keyboard accessibility on Views (alternative impl). (Closed)
DescriptionFix toolbar keyboard accessibility on Views (alternative impl).
This broke when the location bar got moved out of the toolbar's view
hierarchy, it no longer became possible to tab through all of the
controls in the toolbar including the location bar.
To fix this, I have AccessiblePaneView provide its own subclass of
FocusSearch, overriding GetParent and Contains so that the
location bar is considered to be part of the toolbar for focus
searching.
Adds a new test that should catch this type of regression in the future,
while hopefully not being too brittle so it will still succeed as
the toolbar changes over time.
BUG=145835
TEST=Press F6 or Alt+Shift+T to focus the toolbar, then Tab to all of the focusable controls, make sure the location bar is included.
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=157914
Patch Set 1 #Patch Set 2 : Rebase #Patch Set 3 : Fix linux_chromeos compile #
Total comments: 17
Patch Set 4 : git commit -a -m "Assert(false) -> gtest_fail" #Patch Set 5 : address review comments #Patch Set 6 : Fix views_unittest #Patch Set 7 : Fix test on linux_chromeos #
Messages
Total messages: 7 (0 generated)
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
