Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3430)

Unified Diff: chrome/browser/ui/views/location_bar/location_bar_container.cc

Issue 10949005: Fix toolbar keyboard accessibility on Views (alternative impl). (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix test on linux_chromeos Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/location_bar/location_bar_container.cc
diff --git a/chrome/browser/ui/views/location_bar/location_bar_container.cc b/chrome/browser/ui/views/location_bar/location_bar_container.cc
index 19a0894c8b08c1e97e0e0d11d395f50c28fc8c55..199444dcf2e6417975a3adfd5c2522a04a9edee6 100644
--- a/chrome/browser/ui/views/location_bar/location_bar_container.cc
+++ b/chrome/browser/ui/views/location_bar/location_bar_container.cc
@@ -7,6 +7,7 @@
#include "chrome/browser/ui/views/location_bar/location_bar_view.h"
#include "chrome/browser/ui/webui/instant_ui.h"
#include "ui/base/events/event.h"
+#include "ui/views/accessible_pane_view.h"
#include "ui/views/background.h"
namespace {
@@ -16,13 +17,16 @@ const int kAnimationDuration = 180;
}
-LocationBarContainer::LocationBarContainer(views::View* parent,
- bool instant_extended_api_enabled)
+LocationBarContainer::LocationBarContainer(
+ views::View* parent,
+ views::AccessiblePaneView* accessible_pane_view,
+ bool instant_extended_api_enabled)
: animator_(parent),
view_parent_(NULL),
location_bar_view_(NULL),
native_view_host_(NULL),
in_toolbar_(true),
+ accessible_pane_view_(accessible_pane_view),
instant_extended_api_enabled_(instant_extended_api_enabled) {
parent->AddChildView(this);
animator_.set_tween_type(ui::Tween::EASE_IN_OUT);
@@ -83,6 +87,11 @@ void LocationBarContainer::GetAccessibleState(
location_bar_view_->GetAccessibleState(state);
}
+views::FocusTraversable* LocationBarContainer::GetPaneFocusTraversable() {
+ // Use the accessible pane view that this belongs to for focus searching.
+ return accessible_pane_view_->GetPaneFocusTraversable();
+}
+
void LocationBarContainer::OnBoundsAnimatorDone(
views::BoundsAnimator* animator) {
SetInToolbar(true);
« no previous file with comments | « chrome/browser/ui/views/location_bar/location_bar_container.h ('k') | chrome/browser/ui/views/toolbar_view.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698