[Panels] Fix browser crash when killing extension on Windows.

[Panels] Fix browser crash when killing extension on Windows.

BUG=150053
TEST=WindowOpenPanelTest.ClosePanelsOnExtensionCrash


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=157602

[jennb, 2012-09-19 00:59:08]

jianli for main review.
asargent for extensions OWNER review (for the test).

[jennb, 2012-09-19 01:00:07]

On 2012/09/19 00:59:08, jennb wrote:
> jianli for main review.
> asargent for extensions OWNER review (for the test).

Oh, forgot to point out that the new test is essentially the same as the test
above it, CloseNonExtensionPanelsOnUninstall, which should make it easier to
review.

[jianli, 2012-09-19 01:09:43]

lgtm

https://chromiumcodereview.appspot.com/10948027/diff/2001/chrome/browser/ui/p...
File chrome/browser/ui/panels/panel_view.cc (right):

https://chromiumcodereview.appspot.com/10948027/diff/2001/chrome/browser/ui/p...
chrome/browser/ui/panels/panel_view.cc:300: if (panel_->GetWebContents()) {
nit: could you please add comment for why we need to close web contents first?

[jennb, 2012-09-19 01:16:46]

https://chromiumcodereview.appspot.com/10948027/diff/2001/chrome/browser/ui/p...
File chrome/browser/ui/panels/panel_view.cc (right):

https://chromiumcodereview.appspot.com/10948027/diff/2001/chrome/browser/ui/p...
chrome/browser/ui/panels/panel_view.cc:300: if (panel_->GetWebContents()) {
On 2012/09/19 01:09:43, jianli wrote:
> nit: could you please add comment for why we need to close web contents first?

Done. Stole wording from browser_view.cc

[asargent_no_longer_on_chrome, 2012-09-19 18:08:22]

LGTM

[commit-bot: I haz the power, 2012-09-19 18:20:47]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jennb@chromium.org/10948027/1008

[commit-bot: I haz the power, 2012-09-19 20:41:49]

Change committed as 157602