chrome/browser/ui/panels/panel_view.h - Issue 10948027: [Panels] Fix browser crash when killing extension on Windows.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/panels/panel_view.h

Issue 10948027: [Panels] Fix browser crash when killing extension on Windows. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: comment added Created 8 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/panels/panel_view.h

diff --git a/chrome/browser/ui/panels/panel_view.h b/chrome/browser/ui/panels/panel_view.h

index f1019653a6ea26d0174c5bc89a15cb5a26d11207..ae4f5a76a0bf6d8fe140a0e87d6f6cf17cb2e130 100644

--- a/chrome/browser/ui/panels/panel_view.h

+++ b/chrome/browser/ui/panels/panel_view.h

@@ -150,10 +150,12 @@ class PanelView : public NativePanel,

scoped_ptr<Panel> panel_;

gfx::Rect bounds_;

- // The window that holds all panel views.

+ // The window that holds all panel views. Lifetime managed by native widget.

+ // See widget.h.

views::Widget* window_;

- // The view hosting the web contents.

+ // The view hosting the web contents. Will be destroyed when child views

+ // of this class are destroyed.

views::WebView* web_view_;

// True if the panel should always stay on top of other windows.