Issue 10948023: Change the status for window_open_test to fail if not chrome or DRT.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10948023: Change the status for window_open_test to fail if not chrome or DRT. (Closed)

Created:
8 years, 3 months ago by gram

Modified:
8 years, 3 months ago

Reviewers:
ahe, Emily Fortuna

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Change the status for window_open_test to fail if not chrome or DRT. Committed: https://code.google.com/p/dart/source/detail?r=12522

Patch Set 1 #

Total comments: 1

Created: 8 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -0 lines)			Patch
	M	tests/html/html.status	View		1 chunk	+3 lines, -0 lines	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Emily Fortuna

8 years, 3 months ago (2012-09-18 22:41:10 UTC) #2

https://chromiumcodereview.appspot.com/10948023/diff/1/tests/html/html.status
File tests/html/html.status (right):

https://chromiumcodereview.appspot.com/10948023/diff/1/tests/html/html.status...
tests/html/html.status:204: if [ $runtime != chrome && $runtime != drt]
unfortunately, these status files do not have the "not" operator. (Yes,
shocking)
So you have to specify the runtimes where it does fail explicitly:

(also no "if" needed)

[ $compiler == dart2js && ($runtime == ff || $runtime == ie || $runtime ==
safari || $runtime == opera) ]

Expand Messages | Collapse Messages