Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(650)

Issue 10941003: Reset registered events and dispatch runtime.onInstalled to all extensions when (Closed)

Created:
8 years, 3 months ago by Matt Perry
Modified:
8 years, 3 months ago
Reviewers:
Aaron Boodman
CC:
chromium-reviews, mihaip-chromium-reviews_chromium.org
Visibility:
Public.

Description

Reset registered events and dispatch runtime.onInstalled to all extensions when Chrome is updated. BUG=148898 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=157685

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : . #

Total comments: 2

Patch Set 4 : sync #

Patch Set 5 : fix compile #

Patch Set 6 : chromeos fix #

Patch Set 7 : ? #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+107 lines, -19 lines) Patch
M chrome/browser/extensions/api/runtime/runtime_api.h View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/extensions/api/runtime/runtime_api.cc View 1 2 3 chunks +10 lines, -4 lines 0 comments Download
M chrome/browser/extensions/event_router.h View 1 2 3 4 3 chunks +6 lines, -1 line 0 comments Download
M chrome/browser/extensions/event_router.cc View 1 2 3 4 6 chunks +30 lines, -5 lines 0 comments Download
M chrome/browser/extensions/extension_prefs.h View 2 chunks +7 lines, -0 lines 0 comments Download
M chrome/browser/extensions/extension_prefs.cc View 1 2 3 4 5 6 chunks +45 lines, -0 lines 1 comment Download
M chrome/browser/extensions/extension_system.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/extensions/menu_manager_unittest.cc View 1 2 3 4 2 chunks +2 lines, -4 lines 0 comments Download
M chrome/browser/extensions/settings/settings_test_util.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/api/runtime.json View 1 2 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 13 (0 generated)
Matt Perry
8 years, 3 months ago (2012-09-18 00:05:56 UTC) #1
Aaron Boodman
lgtm http://codereview.chromium.org/10941003/diff/4001/chrome/browser/extensions/api/runtime/runtime_api.h File chrome/browser/extensions/api/runtime/runtime_api.h (right): http://codereview.chromium.org/10941003/diff/4001/chrome/browser/extensions/api/runtime/runtime_api.h#newcode27 chrome/browser/extensions/api/runtime/runtime_api.h:27: bool chrome_updated); Is it possible to send old ...
8 years, 3 months ago (2012-09-18 00:19:03 UTC) #2
Matt Perry
http://codereview.chromium.org/10941003/diff/4001/chrome/browser/extensions/api/runtime/runtime_api.h File chrome/browser/extensions/api/runtime/runtime_api.h (right): http://codereview.chromium.org/10941003/diff/4001/chrome/browser/extensions/api/runtime/runtime_api.h#newcode27 chrome/browser/extensions/api/runtime/runtime_api.h:27: bool chrome_updated); On 2012/09/18 00:19:03, Aaron Boodman wrote: > ...
8 years, 3 months ago (2012-09-18 00:57:03 UTC) #3
Aaron Boodman
OK, still lgtm
8 years, 3 months ago (2012-09-18 18:56:15 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mpcomplete@chromium.org/10941003/4001
8 years, 3 months ago (2012-09-18 18:58:55 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mpcomplete@chromium.org/10941003/8004
8 years, 3 months ago (2012-09-18 19:11:57 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mpcomplete@chromium.org/10941003/9004
8 years, 3 months ago (2012-09-18 19:32:00 UTC) #7
commit-bot: I haz the power
Retried try job too often for step(s) browser_tests
8 years, 3 months ago (2012-09-18 22:31:59 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mpcomplete@chromium.org/10941003/9004
8 years, 3 months ago (2012-09-18 22:37:40 UTC) #9
commit-bot: I haz the power
Retried try job too often for step(s) browser_tests
8 years, 3 months ago (2012-09-19 01:41:01 UTC) #10
Matt Perry
http://codereview.chromium.org/10941003/diff/10005/chrome/browser/extensions/extension_prefs.cc File chrome/browser/extensions/extension_prefs.cc (right): http://codereview.chromium.org/10941003/diff/10005/chrome/browser/extensions/extension_prefs.cc#newcode1038 chrome/browser/extensions/extension_prefs.cc:1038: if (CommandLine::ForCurrentProcess()->HasSwitch(switches::kTestType)) I had to add this bit to ...
8 years, 3 months ago (2012-09-19 23:32:46 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mpcomplete@chromium.org/10941003/10005
8 years, 3 months ago (2012-09-19 23:33:04 UTC) #12
commit-bot: I haz the power
8 years, 3 months ago (2012-09-20 02:23:33 UTC) #13
Change committed as 157685

Powered by Google App Engine
This is Rietveld 408576698