Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Side by Side Diff: chrome/browser/extensions/event_router.cc

Issue 10941003: Reset registered events and dispatch runtime.onInstalled to all extensions when (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: ? Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/extensions/event_router.h" 5 #include "chrome/browser/extensions/event_router.h"
6 6
7 #include "base/bind.h" 7 #include "base/bind.h"
8 #include "base/command_line.h" 8 #include "base/command_line.h"
9 #include "base/message_loop.h" 9 #include "base/message_loop.h"
10 #include "base/values.h" 10 #include "base/values.h"
11 #include "base/version.h" 11 #include "base/version.h"
12 #include "chrome/browser/browser_process.h" 12 #include "chrome/browser/browser_process.h"
13 #include "chrome/browser/extensions/api/processes/processes_api.h" 13 #include "chrome/browser/extensions/api/processes/processes_api.h"
14 #include "chrome/browser/extensions/api/processes/processes_api_constants.h" 14 #include "chrome/browser/extensions/api/processes/processes_api_constants.h"
15 #include "chrome/browser/extensions/api/runtime/runtime_api.h" 15 #include "chrome/browser/extensions/api/runtime/runtime_api.h"
16 #include "chrome/browser/extensions/api/web_request/web_request_api.h" 16 #include "chrome/browser/extensions/api/web_request/web_request_api.h"
17 #include "chrome/browser/extensions/extension_devtools_manager.h" 17 #include "chrome/browser/extensions/extension_devtools_manager.h"
18 #include "chrome/browser/extensions/extension_host.h" 18 #include "chrome/browser/extensions/extension_host.h"
19 #include "chrome/browser/extensions/extension_prefs.h"
19 #include "chrome/browser/extensions/extension_process_manager.h" 20 #include "chrome/browser/extensions/extension_process_manager.h"
20 #include "chrome/browser/extensions/extension_service.h" 21 #include "chrome/browser/extensions/extension_service.h"
21 #include "chrome/browser/extensions/extension_system.h" 22 #include "chrome/browser/extensions/extension_system.h"
22 #include "chrome/browser/extensions/event_names.h" 23 #include "chrome/browser/extensions/event_names.h"
23 #include "chrome/browser/extensions/lazy_background_task_queue.h" 24 #include "chrome/browser/extensions/lazy_background_task_queue.h"
24 #include "chrome/browser/extensions/process_map.h" 25 #include "chrome/browser/extensions/process_map.h"
25 #include "chrome/browser/extensions/system_info_event_router.h" 26 #include "chrome/browser/extensions/system_info_event_router.h"
26 #include "chrome/browser/profiles/profile.h" 27 #include "chrome/browser/profiles/profile.h"
27 #include "chrome/browser/profiles/profile_manager.h" 28 #include "chrome/browser/profiles/profile_manager.h"
28 #include "chrome/common/chrome_notification_types.h" 29 #include "chrome/common/chrome_notification_types.h"
(...skipping 18 matching lines...) Expand all
47 void* profile, 48 void* profile,
48 const std::string& extension_id, 49 const std::string& extension_id,
49 const std::string& sub_event_name) { 50 const std::string& sub_event_name) {
50 ExtensionWebRequestEventRouter::GetInstance()->RemoveEventListener( 51 ExtensionWebRequestEventRouter::GetInstance()->RemoveEventListener(
51 profile, extension_id, sub_event_name); 52 profile, extension_id, sub_event_name);
52 } 53 }
53 54
54 void DispatchOnInstalledEvent( 55 void DispatchOnInstalledEvent(
55 Profile* profile, 56 Profile* profile,
56 const std::string& extension_id, 57 const std::string& extension_id,
57 const Version& old_version) { 58 const Version& old_version,
59 bool chrome_updated) {
58 if (!g_browser_process->profile_manager()->IsValidProfile(profile)) 60 if (!g_browser_process->profile_manager()->IsValidProfile(profile))
59 return; 61 return;
60 62
61 RuntimeEventRouter::DispatchOnInstalledEvent(profile, extension_id, 63 RuntimeEventRouter::DispatchOnInstalledEvent(profile, extension_id,
62 old_version); 64 old_version, chrome_updated);
63 } 65 }
64 66
65 } // namespace 67 } // namespace
66 68
67 struct EventRouter::ListenerProcess { 69 struct EventRouter::ListenerProcess {
68 content::RenderProcessHost* process; 70 content::RenderProcessHost* process;
69 std::string extension_id; 71 std::string extension_id;
70 72
71 ListenerProcess(content::RenderProcessHost* process, 73 ListenerProcess(content::RenderProcessHost* process,
72 const std::string& extension_id) 74 const std::string& extension_id)
(...skipping 35 matching lines...) Expand 10 before | Expand all | Expand 10 after
108 const std::string& extension_id, 110 const std::string& extension_id,
109 const std::string& event_name, 111 const std::string& event_name,
110 scoped_ptr<ListValue> event_args, 112 scoped_ptr<ListValue> event_args,
111 const GURL& event_url, 113 const GURL& event_url,
112 UserGestureState user_gesture, 114 UserGestureState user_gesture,
113 const EventFilteringInfo& info) { 115 const EventFilteringInfo& info) {
114 DispatchExtensionMessage(ipc_sender, extension_id, event_name, 116 DispatchExtensionMessage(ipc_sender, extension_id, event_name,
115 event_args.get(), event_url, user_gesture, info); 117 event_args.get(), event_url, user_gesture, info);
116 } 118 }
117 119
118 EventRouter::EventRouter(Profile* profile) 120 EventRouter::EventRouter(Profile* profile, ExtensionPrefs* extension_prefs)
119 : profile_(profile), 121 : profile_(profile),
120 extension_devtools_manager_( 122 extension_devtools_manager_(
121 ExtensionSystem::Get(profile)->devtools_manager()), 123 ExtensionSystem::Get(profile)->devtools_manager()),
122 listeners_(ALLOW_THIS_IN_INITIALIZER_LIST(this)) { 124 listeners_(ALLOW_THIS_IN_INITIALIZER_LIST(this)),
125 dispatch_chrome_updated_event_(false) {
123 registrar_.Add(this, content::NOTIFICATION_RENDERER_PROCESS_TERMINATED, 126 registrar_.Add(this, content::NOTIFICATION_RENDERER_PROCESS_TERMINATED,
124 content::NotificationService::AllSources()); 127 content::NotificationService::AllSources());
125 registrar_.Add(this, content::NOTIFICATION_RENDERER_PROCESS_CLOSED, 128 registrar_.Add(this, content::NOTIFICATION_RENDERER_PROCESS_CLOSED,
126 content::NotificationService::AllSources()); 129 content::NotificationService::AllSources());
130 registrar_.Add(this, chrome::NOTIFICATION_EXTENSIONS_READY,
131 content::Source<Profile>(profile_));
127 registrar_.Add(this, chrome::NOTIFICATION_EXTENSION_LOADED, 132 registrar_.Add(this, chrome::NOTIFICATION_EXTENSION_LOADED,
128 content::Source<Profile>(profile_)); 133 content::Source<Profile>(profile_));
129 registrar_.Add(this, chrome::NOTIFICATION_EXTENSION_UNLOADED, 134 registrar_.Add(this, chrome::NOTIFICATION_EXTENSION_UNLOADED,
130 content::Source<Profile>(profile_)); 135 content::Source<Profile>(profile_));
131 registrar_.Add(this, chrome::NOTIFICATION_EXTENSION_INSTALLED, 136 registrar_.Add(this, chrome::NOTIFICATION_EXTENSION_INSTALLED,
132 content::Source<Profile>(profile_)); 137 content::Source<Profile>(profile_));
138
139 // NULL in unit_tests.
140 if (extension_prefs) {
141 // Check if registered events are up-to-date. We need to do this before
142 // reading the registered events, because it deletes them if they're out of
143 // date.
144 dispatch_chrome_updated_event_ =
145 !extension_prefs->CheckRegisteredEventsUpToDate();
146 }
133 } 147 }
134 148
135 EventRouter::~EventRouter() {} 149 EventRouter::~EventRouter() {}
136 150
137 void EventRouter::AddEventListener(const std::string& event_name, 151 void EventRouter::AddEventListener(const std::string& event_name,
138 content::RenderProcessHost* process, 152 content::RenderProcessHost* process,
139 const std::string& extension_id) { 153 const std::string& extension_id) {
140 listeners_.AddListener(scoped_ptr<EventListener>(new EventListener( 154 listeners_.AddListener(scoped_ptr<EventListener>(new EventListener(
141 event_name, extension_id, process, scoped_ptr<DictionaryValue>()))); 155 event_name, extension_id, process, scoped_ptr<DictionaryValue>())));
142 } 156 }
(...skipping 405 matching lines...) Expand 10 before | Expand all | Expand 10 after
548 const content::NotificationDetails& details) { 562 const content::NotificationDetails& details) {
549 switch (type) { 563 switch (type) {
550 case content::NOTIFICATION_RENDERER_PROCESS_TERMINATED: 564 case content::NOTIFICATION_RENDERER_PROCESS_TERMINATED:
551 case content::NOTIFICATION_RENDERER_PROCESS_CLOSED: { 565 case content::NOTIFICATION_RENDERER_PROCESS_CLOSED: {
552 content::RenderProcessHost* renderer = 566 content::RenderProcessHost* renderer =
553 content::Source<content::RenderProcessHost>(source).ptr(); 567 content::Source<content::RenderProcessHost>(source).ptr();
554 // Remove all event listeners associated with this renderer. 568 // Remove all event listeners associated with this renderer.
555 listeners_.RemoveListenersForProcess(renderer); 569 listeners_.RemoveListenersForProcess(renderer);
556 break; 570 break;
557 } 571 }
572 case chrome::NOTIFICATION_EXTENSIONS_READY: {
573 // We're done restarting Chrome after an update.
574 dispatch_chrome_updated_event_ = false;
575 break;
576 }
558 case chrome::NOTIFICATION_EXTENSION_LOADED: { 577 case chrome::NOTIFICATION_EXTENSION_LOADED: {
559 // Add all registered lazy listeners to our cache. 578 // Add all registered lazy listeners to our cache.
560 const Extension* extension = 579 const Extension* extension =
561 content::Details<const Extension>(details).ptr(); 580 content::Details<const Extension>(details).ptr();
562 ExtensionPrefs* prefs = 581 ExtensionPrefs* prefs =
563 profile_->GetExtensionService()->extension_prefs(); 582 profile_->GetExtensionService()->extension_prefs();
564 std::set<std::string> registered_events = 583 std::set<std::string> registered_events =
565 prefs->GetRegisteredEvents(extension->id()); 584 prefs->GetRegisteredEvents(extension->id());
566 listeners_.LoadUnfilteredLazyListeners(extension->id(), 585 listeners_.LoadUnfilteredLazyListeners(extension->id(),
567 registered_events); 586 registered_events);
568 const DictionaryValue* filtered_events = 587 const DictionaryValue* filtered_events =
569 prefs->GetFilteredEvents(extension->id()); 588 prefs->GetFilteredEvents(extension->id());
570 if (filtered_events) 589 if (filtered_events)
571 listeners_.LoadFilteredLazyListeners(extension->id(), *filtered_events); 590 listeners_.LoadFilteredLazyListeners(extension->id(), *filtered_events);
591
592 if (dispatch_chrome_updated_event_) {
593 MessageLoop::current()->PostTask(FROM_HERE,
594 base::Bind(&DispatchOnInstalledEvent, profile_, extension->id(),
595 Version(), true));
596 }
572 break; 597 break;
573 } 598 }
574 case chrome::NOTIFICATION_EXTENSION_UNLOADED: { 599 case chrome::NOTIFICATION_EXTENSION_UNLOADED: {
575 // Remove all registered lazy listeners from our cache. 600 // Remove all registered lazy listeners from our cache.
576 UnloadedExtensionInfo* unloaded = 601 UnloadedExtensionInfo* unloaded =
577 content::Details<UnloadedExtensionInfo>(details).ptr(); 602 content::Details<UnloadedExtensionInfo>(details).ptr();
578 listeners_.RemoveLazyListenersForExtension(unloaded->extension->id()); 603 listeners_.RemoveLazyListenersForExtension(unloaded->extension->id());
579 break; 604 break;
580 } 605 }
581 case chrome::NOTIFICATION_EXTENSION_INSTALLED: { 606 case chrome::NOTIFICATION_EXTENSION_INSTALLED: {
582 // Dispatch the onInstalled event. 607 // Dispatch the onInstalled event.
583 const Extension* extension = 608 const Extension* extension =
584 content::Details<const Extension>(details).ptr(); 609 content::Details<const Extension>(details).ptr();
585 610
586 // Get the previous version, if this is an upgrade. 611 // Get the previous version, if this is an upgrade.
587 ExtensionService* service = 612 ExtensionService* service =
588 ExtensionSystem::Get(profile_)->extension_service(); 613 ExtensionSystem::Get(profile_)->extension_service();
589 const Extension* old = service->GetExtensionById(extension->id(), true); 614 const Extension* old = service->GetExtensionById(extension->id(), true);
590 Version old_version; 615 Version old_version;
591 if (old) 616 if (old)
592 old_version = *old->version(); 617 old_version = *old->version();
593 618
594 MessageLoop::current()->PostTask(FROM_HERE, 619 MessageLoop::current()->PostTask(FROM_HERE,
595 base::Bind(&DispatchOnInstalledEvent, profile_, extension->id(), 620 base::Bind(&DispatchOnInstalledEvent, profile_, extension->id(),
596 old_version)); 621 old_version, false));
597 break; 622 break;
598 } 623 }
599 default: 624 default:
600 NOTREACHED(); 625 NOTREACHED();
601 return; 626 return;
602 } 627 }
603 } 628 }
604 629
605 Event::Event(const std::string& event_name, 630 Event::Event(const std::string& event_name,
606 scoped_ptr<ListValue> event_args, 631 scoped_ptr<ListValue> event_args,
(...skipping 20 matching lines...) Expand all
627 event_args(event_args.Pass()), 652 event_args(event_args.Pass()),
628 event_url(event_url), 653 event_url(event_url),
629 restrict_to_profile(restrict_to_profile), 654 restrict_to_profile(restrict_to_profile),
630 cross_incognito_args(NULL), 655 cross_incognito_args(NULL),
631 user_gesture(user_gesture), 656 user_gesture(user_gesture),
632 info(info) {} 657 info(info) {}
633 658
634 Event::~Event() {} 659 Event::~Event() {}
635 660
636 } // namespace extensions 661 } // namespace extensions
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698