Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(53)

Issue 10939011: Reland "Revert 156830 - drive: Stop exposing operation_registry() from DriveServiceInterface" (Closed)

Created:
8 years, 3 months ago by hashimoto
Modified:
8 years, 3 months ago
Reviewers:
CC:
chromium-reviews, mihaip-chromium-reviews_chromium.org, nkostylev+watch_chromium.org, derat+watch_chromium.org, achuith+watch_chromium.org, Aaron Boodman, rginda+watch_chromium.org, oshima+watch_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org
Visibility:
Public.

Description

Reland 156830 - drive: Stop exposing operation_registry() from DriveServiceInterface Remove DriveServiceInterface::operation_registry() Add the following methods to DriveServiceInterface: CancelForFilePath(), GetProgressStatusList() Add the following methods to DriveServiceObserver and wire these events: OnProgressUpdate(), OnAuthenticationFailed() Move the following types out from OperationRegistry: OperationType, OperationTransferState, OperationProgressUpdate, OperationProgressUpdateList Move the following functions out from OperationRegistry: OperationTypeToString(), OperationTransferStateToString() BUG=147358 TEST=git try -b linux_chromeos

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+243 lines, -201 lines) Patch
M chrome/browser/chromeos/extensions/external_filesystem_apitest.cc View 3 chunks +0 lines, -8 lines 0 comments Download
M chrome/browser/chromeos/extensions/file_browser_event_router.h View 3 chunks +4 lines, -5 lines 0 comments Download
M chrome/browser/chromeos/extensions/file_browser_event_router.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/extensions/file_browser_private_api.cc View 5 chunks +3 lines, -9 lines 0 comments Download
M chrome/browser/chromeos/extensions/file_manager_util.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/extensions/file_manager_util.cc View 5 chunks +5 lines, -10 lines 0 comments Download
M chrome/browser/chromeos/gdata/drive_api_service.h View 4 chunks +11 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/gdata/drive_api_service.cc View 6 chunks +31 lines, -5 lines 0 comments Download
M chrome/browser/chromeos/gdata/drive_protocol_handler.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/chromeos/gdata/drive_service_interface.h View 2 chunks +14 lines, -4 lines 0 comments Download
M chrome/browser/chromeos/gdata/gdata_contacts_service.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/chromeos/gdata/gdata_wapi_service.h View 3 chunks +11 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/gdata/gdata_wapi_service.cc View 6 chunks +31 lines, -5 lines 0 comments Download
M chrome/browser/chromeos/gdata/mock_drive_service.h View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/chromeos/system/ash_system_tray_delegate.cc View 11 chunks +14 lines, -25 lines 0 comments Download
M chrome/browser/google_apis/gdata_operations.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/google_apis/gdata_operations_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/google_apis/operation_registry.h View 6 chunks +60 lines, -56 lines 0 comments Download
M chrome/browser/google_apis/operation_registry.cc View 11 chunks +16 lines, -19 lines 0 comments Download
M chrome/browser/google_apis/operation_registry_unittest.cc View 8 chunks +16 lines, -18 lines 0 comments Download
M chrome/browser/google_apis/operations_base.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/google_apis/operations_base.cc View 6 chunks +8 lines, -9 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/drive_internals_ui.cc View 2 chunks +5 lines, -9 lines 0 comments Download

Powered by Google App Engine
This is Rietveld 408576698