Reland "Revert 156830 - drive: Stop exposing operation_registry() from DriveServiceInterface"

chrome/browser/google_apis/operation_registry_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/google_apis/operation_registry.h"
 
 #include "base/compiler_specific.h"
 #include "base/memory/weak_ptr.h"
 #include "base/message_loop.h"
 #include "content/public/test/test_browser_thread.h"
 #include "testing/gmock/include/gmock/gmock.h"
 #include "testing/gtest/include/gtest/gtest.h"
 
 using testing::ElementsAre;
 
 namespace gdata {
 
 namespace {
 
 class MockOperation : public OperationRegistry::Operation,
                       public base::SupportsWeakPtr<MockOperation> {
  public:
   MockOperation(OperationRegistry* registry,
-                OperationRegistry::OperationType type,
+                OperationType type,
                 const FilePath& path)
       : OperationRegistry::Operation(registry, type, path) {}
 
   MOCK_METHOD0(DoCancel, void());
 
   // Make them public so that they can be called from test cases.
   using OperationRegistry::Operation::NotifyStart;
   using OperationRegistry::Operation::NotifyProgress;
   using OperationRegistry::Operation::NotifyFinish;
 };
 
 class MockUploadOperation : public MockOperation {
  public:
   explicit MockUploadOperation(OperationRegistry* registry)
       : MockOperation(registry,
-                      OperationRegistry::OPERATION_UPLOAD,
+                      OPERATION_UPLOAD,
                       FilePath(FILE_PATH_LITERAL("/dummy/upload"))) {}
 };
 
 class MockDownloadOperation : public MockOperation {
  public:
   explicit MockDownloadOperation(OperationRegistry* registry)
       : MockOperation(registry,
-                      OperationRegistry::OPERATION_DOWNLOAD,
+                      OPERATION_DOWNLOAD,
                       FilePath(FILE_PATH_LITERAL("/dummy/download"))) {}
 };
 
 class MockOtherOperation : public MockOperation {
  public:
   explicit MockOtherOperation(OperationRegistry* registry)
       : MockOperation(registry,
-                      OperationRegistry::OPERATION_OTHER,
+                      OPERATION_OTHER,
                       FilePath(FILE_PATH_LITERAL("/dummy/other"))) {}
 };
 
 class TestObserver : public OperationRegistry::Observer {
  public:
   virtual void OnProgressUpdate(
-      const std::vector<OperationRegistry::ProgressStatus>& list)
-      OVERRIDE {
+      const OperationProgressStatusList& list) OVERRIDE {
     status_ = list;
   }
 
-  const std::vector<OperationRegistry::ProgressStatus>& status() const {
+  const OperationProgressStatusList& status() const {
     return status_;
   }
 
  private:
-  std::vector<OperationRegistry::ProgressStatus> status_;
+  OperationProgressStatusList status_;
 };
 
 class ProgressMatcher
-    : public ::testing::MatcherInterface<
-        const OperationRegistry::ProgressStatus&> {
+    : public ::testing::MatcherInterface<const OperationProgressStatus&> {
  public:
   ProgressMatcher(int64 expected_current, int64 expected_total)
       : expected_current_(expected_current),
         expected_total_(expected_total) {}
 
   virtual bool MatchAndExplain(
-      const OperationRegistry::ProgressStatus& status,
+      const OperationProgressStatus& status,
       testing::MatchResultListener* /* listener */) const OVERRIDE {
     return status.progress_current == expected_current_ &&
         status.progress_total == expected_total_;
   }
 
   virtual void DescribeTo(::std::ostream* os) const OVERRIDE {
     *os << "current / total equals " << expected_current_ << " / " <<
         expected_total_;
   }
 
   virtual void DescribeNegationTo(::std::ostream* os) const OVERRIDE {
     *os << "current / total does not equal " << expected_current_ << " / " <<
         expected_total_;
   }
 
  private:
   const int64 expected_current_;
   const int64 expected_total_;
 };
 
-testing::Matcher<const OperationRegistry::ProgressStatus&> Progress(
+testing::Matcher<const OperationProgressStatus&> Progress(
     int64 current, int64 total) {
   return testing::MakeMatcher(new ProgressMatcher(current, total));
 }
 
 }  // namespace
 
-// Pretty-prints ProgressStatus for testing purpose.
+// Pretty-prints OperationProgressStatus for testing purpose.
 std::ostream& operator<<(std::ostream& os,
-                         const OperationRegistry::ProgressStatus& status) {
+                         const OperationProgressStatus& status) {
   return os << status.DebugString();
 }
 
 class OperationRegistryTest : public testing::Test {
  protected:
   OperationRegistryTest()
       : ui_thread_(content::BrowserThread::UI, &message_loop_) {
   }
   MessageLoopForUI message_loop_;
   content::TestBrowserThread ui_thread_;
 };
 
 TEST_F(OperationRegistryTest, OneSuccess) {
   TestObserver observer;
   OperationRegistry registry;
   registry.DisableNotificationFrequencyControlForTest();
   registry.AddObserver(&observer);
 
   base::WeakPtr<MockOperation> op1 =
       (new MockUploadOperation(&registry))->AsWeakPtr();
   EXPECT_CALL(*op1, DoCancel()).Times(0);
 
   EXPECT_EQ(0U, observer.status().size());
   op1->NotifyStart();
   EXPECT_THAT(observer.status(), ElementsAre(Progress(0, -1)));
   op1->NotifyProgress(0, 100);
   EXPECT_THAT(observer.status(), ElementsAre(Progress(0, 100)));
   op1->NotifyProgress(100, 100);
   EXPECT_THAT(observer.status(), ElementsAre(Progress(100, 100)));
-  op1->NotifyFinish(OperationRegistry::OPERATION_COMPLETED);
+  op1->NotifyFinish(OPERATION_COMPLETED);
   // Contains one "COMPLETED" notification.
   EXPECT_THAT(observer.status(), ElementsAre(Progress(100, 100)));
   // Then it is removed.
   EXPECT_EQ(0U, registry.GetProgressStatusList().size());
   EXPECT_EQ(NULL, op1.get());  // deleted
 }
 
 TEST_F(OperationRegistryTest, OneCancel) {
   TestObserver observer;
   OperationRegistry registry;
@@ skipping 30 matching lines @@
 
   EXPECT_EQ(0U, observer.status().size());
   op1->NotifyStart();
   op1->NotifyProgress(0, 100);
   EXPECT_THAT(observer.status(), ElementsAre(Progress(0, 100)));
   op2->NotifyStart();
   op2->NotifyProgress(0, 200);
   op1->NotifyProgress(50, 100);
   EXPECT_THAT(observer.status(), ElementsAre(Progress(50, 100),
                                              Progress(0, 200)));
-  op1->NotifyFinish(OperationRegistry::OPERATION_COMPLETED);
+  op1->NotifyFinish(OPERATION_COMPLETED);
   EXPECT_THAT(observer.status(), ElementsAre(Progress(50, 100),
                                              Progress(0, 200)));
   EXPECT_EQ(1U, registry.GetProgressStatusList().size());
-  op2->NotifyFinish(OperationRegistry::OPERATION_COMPLETED);
+  op2->NotifyFinish(OPERATION_COMPLETED);
   EXPECT_THAT(observer.status(), ElementsAre(Progress(0, 200)));
   EXPECT_EQ(0U, registry.GetProgressStatusList().size());
   EXPECT_EQ(NULL, op1.get());  // deleted
   EXPECT_EQ(NULL, op2.get());  // deleted
 }
 
 TEST_F(OperationRegistryTest, ThreeCancel) {
   TestObserver observer;
   OperationRegistry registry;
   registry.DisableNotificationFrequencyControlForTest();
@@ skipping 32 matching lines @@
 
   base::WeakPtr<MockOperation> op1 =
       (new MockUploadOperation(&registry))->AsWeakPtr();
   EXPECT_CALL(*op1, DoCancel()).Times(0);
 
   op1->NotifyStart();
   EXPECT_EQ(1U, registry.GetProgressStatusList().size());
   op1->NotifyStart();  // restart
   EXPECT_EQ(1U, registry.GetProgressStatusList().size());
   op1->NotifyProgress(0, 200);
-  op1->NotifyFinish(OperationRegistry::OPERATION_COMPLETED);
+  op1->NotifyFinish(OPERATION_COMPLETED);
   EXPECT_EQ(0U, registry.GetProgressStatusList().size());
   EXPECT_EQ(NULL, op1.get());  // deleted
 }
 
 }  // namespace gdata