Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(715)

Issue 10938033: Switch BlockedContentTabHelper to use WebContentsUserData. (Closed)

Created:
8 years, 3 months ago by Avi (use Gerrit)
Modified:
8 years, 3 months ago
CC:
chromium-reviews, joi+watch-content_chromium.org, Avi (use Gerrit), creis+watch_chromium.org, tfarina, jam, samarth, sreeram, gideonwald, dominich, David Black, Shishir, rdsmith+dwatch_chromium.org, ajwong+watch_chromium.org, darin-cc_chromium.org, Jered
Visibility:
Public.

Description

Switch BlockedContentTabHelper to use WebContentsUserData. BUG=107201 TEST=no visible change Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=158051

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+169 lines, -153 lines) Patch
M chrome/browser/download/download_request_limiter.cc View 1 chunk +6 lines, -8 lines 0 comments Download
M chrome/browser/instant/instant_loader.cc View 1 2 2 chunks +4 lines, -2 lines 0 comments Download
M chrome/browser/popup_blocker_browsertest.cc View 5 chunks +13 lines, -16 lines 0 comments Download
M chrome/browser/ui/blocked_content/blocked_content_container.h View 3 chunks +17 lines, -13 lines 0 comments Download
M chrome/browser/ui/blocked_content/blocked_content_container.cc View 7 chunks +43 lines, -40 lines 0 comments Download
M chrome/browser/ui/blocked_content/blocked_content_tab_helper.h View 3 chunks +20 lines, -17 lines 0 comments Download
M chrome/browser/ui/blocked_content/blocked_content_tab_helper.cc View 6 chunks +25 lines, -20 lines 0 comments Download
M chrome/browser/ui/blocked_content/blocked_content_tab_helper_delegate.h View 2 chunks +5 lines, -2 lines 0 comments Download
M chrome/browser/ui/browser.h View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/browser.cc View 1 2 2 chunks +5 lines, -6 lines 0 comments Download
M chrome/browser/ui/browser_adoption.cc View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/browser_tabstrip.cc View 2 chunks +9 lines, -8 lines 0 comments Download
M chrome/browser/ui/content_settings/content_setting_bubble_model.cc View 2 chunks +11 lines, -8 lines 0 comments Download
M chrome/browser/ui/tab_contents/tab_contents.h View 1 2 3 chunks +0 lines, -6 lines 0 comments Download
M chrome/browser/ui/tab_contents/tab_contents.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/external_tab_container_win.h View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/views/external_tab_container_win.cc View 2 chunks +4 lines, -3 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
Avi (use Gerrit)
Blocked contents has no OWNER, but jochen, you're owner of content settings, which is close ...
8 years, 3 months ago (2012-09-20 22:20:52 UTC) #1
jochen (gone - plz use gerrit)
lgtm
8 years, 3 months ago (2012-09-21 10:12:44 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/avi@chromium.org/10938033/5001
8 years, 3 months ago (2012-09-21 14:05:20 UTC) #3
commit-bot: I haz the power
Presubmit check for 10938033-5001 failed and returned exit status 1. Running presubmit commit checks ...
8 years, 3 months ago (2012-09-21 14:05:29 UTC) #4
Avi (use Gerrit)
8 years, 3 months ago (2012-09-21 15:17:30 UTC) #5
Ben Goodger (Google)
lgtm
8 years, 3 months ago (2012-09-21 18:06:36 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/avi@chromium.org/10938033/5001
8 years, 3 months ago (2012-09-21 18:09:50 UTC) #7
commit-bot: I haz the power
8 years, 3 months ago (2012-09-21 19:49:47 UTC) #8
Change committed as 158051

Powered by Google App Engine
This is Rietveld 408576698