Switch BlockedContentTabHelper to use WebContentsUserData.

chrome/browser/download/download_request_limiter.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/download/download_request_limiter.h"
 
 #include "base/bind.h"
 #include "base/stl_util.h"
 #include "chrome/browser/download/download_request_infobar_delegate.h"
 #include "chrome/browser/infobars/infobar_tab_helper.h"
@@ skipping 283 matching lines @@
           originating_contents->GetRenderViewHost(),
           request_id,
           request_method)) {
     ScheduleNotification(callback, false);
     return;
   }
 
   // If the tab requesting the download is a constrained popup that is not
   // shown, treat the request as if it came from the parent.
   WebContents* effective_contents = originating_contents;
-  TabContents* originating_tab_contents =
-     TabContents::FromWebContents(originating_contents);
-  if (originating_tab_contents &&
-      originating_tab_contents->blocked_content_tab_helper()->delegate()) {
-    effective_contents =
-        originating_tab_contents->blocked_content_tab_helper()->delegate()->
-            GetConstrainingTabContents(originating_tab_contents)->
-                web_contents();
+  BlockedContentTabHelper* blocked_content_tab_helper =
+      BlockedContentTabHelper::FromWebContents(originating_contents);
+  if (blocked_content_tab_helper &&
+      blocked_content_tab_helper->delegate()) {
+    effective_contents = blocked_content_tab_helper->delegate()->
+        GetConstrainingWebContents(originating_contents);
   }
 
   TabDownloadState* state = GetDownloadState(
       effective_contents, originating_contents, true);
   switch (state->download_status()) {
     case ALLOW_ALL_DOWNLOADS:
       if (state->download_count() && !(state->download_count() %
             DownloadRequestLimiter::kMaxDownloadsAtOnce))
         state->set_download_status(PROMPT_BEFORE_DOWNLOAD);
       ScheduleNotification(callback, true);
@@ skipping 27 matching lines @@
 
 void DownloadRequestLimiter::Remove(TabDownloadState* state) {
   DCHECK(ContainsKey(state_map_, state->web_contents()));
   state_map_.erase(state->web_contents());
   delete state;
 }
 
 // static
 DownloadRequestLimiter::TestingDelegate* DownloadRequestLimiter::delegate_ =
     NULL;