Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1100)

Issue 10938008: Initialize user agent name to avoid assertion failures. (Closed)

Created:
8 years, 3 months ago by tkent
Modified:
8 years, 3 months ago
Reviewers:
tony
CC:
chromium-reviews, darin-cc_chromium.org
Visibility:
Public.

Description

Initialize user agent name to avoid assertion failures. cpp_bound_class_unittest depended on UA initialization by BookmarkletTest.*, and r157155 moved BookmarkletTes.* to content_browsertest. It caused assertion failures during loading the blank page. BUG=none TEST=none; This fixes existing tests.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M webkit/glue/cpp_bound_class_unittest.cc View 2 chunks +5 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
tkent
This fixes assertion failures in test_shell_tests since r157155. [1075:-1602484928:168608774677:FATAL:user_agent.cc(107)] Check failed: !user_agent_.empty(). Backtrace: 0 libbase.dylib ...
8 years, 3 months ago (2012-09-18 05:21:33 UTC) #1
tony
LGTM, thanks for fixing!
8 years, 3 months ago (2012-09-18 17:06:58 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tkent@chromium.org/10938008/1
8 years, 3 months ago (2012-09-18 17:07:06 UTC) #3
commit-bot: I haz the power
Failed to apply patch for webkit/glue/cpp_bound_class_unittest.cc: While running patch -p1 --forward --force; patching file webkit/glue/cpp_bound_class_unittest.cc ...
8 years, 3 months ago (2012-09-18 17:07:07 UTC) #4
tony
Ah, already landed in https://codereview.chromium.org/10947005/
8 years, 3 months ago (2012-09-18 17:09:13 UTC) #5
tkent
8 years, 3 months ago (2012-09-19 00:42:28 UTC) #6
On 2012/09/18 17:09:13, tony wrote:
> Ah, already landed in https://codereview.chromium.org/10947005/

Oh, that's fine.

Powered by Google App Engine
This is Rietveld 408576698