utils/pub/hosted_source.dart - Issue 10938003: Don't extract the name of a package from its description.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: utils/pub/hosted_source.dart

Issue 10938003: Don't extract the name of a package from its description. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Code review changes Created 8 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: utils/pub/hosted_source.dart

diff --git a/utils/pub/hosted_source.dart b/utils/pub/hosted_source.dart

index 7c450a6468ad1acc610fc53a8cb70b54cf9d7a37..1a1534752ce0ce71a0e63e3fe7c10cc3b935e513 100644

--- a/utils/pub/hosted_source.dart

+++ b/utils/pub/hosted_source.dart

@@ -31,7 +31,7 @@ class HostedSource extends Source {

* Downloads a list of all versions of a package that are available from the

* site.

- Future<List<Version>> getVersions(description) {

+ Future<List<Version>> getVersions(String name, description) {

var parsed = _parseDescription(description);

var fullUrl = "${parsed.last}/packages/${parsed.first}.json";

« no previous file with comments | « utils/pub/git_source.dart ('k') | utils/pub/lock_file.dart » ('j') | no next file with comments »