utils/pub/lock_file.dart - Issue 10938003: Don't extract the name of a package from its description.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: utils/pub/lock_file.dart

Issue 10938003: Don't extract the name of a package from its description. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Code review changes Created 8 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: utils/pub/lock_file.dart

diff --git a/utils/pub/lock_file.dart b/utils/pub/lock_file.dart

index a296e8d9b7efcab8712ab9c5663d72f44a64a844..8e7042330731cdf8cdfb6b3953a4af83112c39f7 100644

--- a/utils/pub/lock_file.dart

+++ b/utils/pub/lock_file.dart

@@ -63,7 +63,7 @@ class LockFile {

var description = spec['description'];

source.validateDescription(description, fromLockFile: true);

- var id = new PackageId(source, version, description);

+ var id = new PackageId(name, source, version, description);

// Validate the name.

if (name != id.name) {

« no previous file with comments | « utils/pub/hosted_source.dart ('k') | utils/pub/package.dart » ('j') | no next file with comments »