contacts: Don't save deleted contacts to disk.

contacts: Don't save deleted contacts to disk.

GoogleContactStore was previously passing all contacts to
ContactDatabase regardless of their "deleted" flag.  This
change makes it instead not save already-deleted contacts,
drop contacts when they become deleted, and track the
most-recent last-updated time from a deleted contact (which
is needed for incremental updates).

BUG=128805
TEST=none


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=161159

[satorux1, 2012-10-10 01:44:17]

I'm terribly sorry for the super belated response. Somehow I missed this. LGTM

[commit-bot: I haz the power, 2012-10-10 17:46:54]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/derat@chromium.org/10933127/6002

[tfarina, 2012-10-10 19:44:39]

http://codereview.chromium.org/10933127/diff/6002/chrome/browser/chromeos/con...
File chrome/browser/chromeos/contacts/contact_database.h (right):

http://codereview.chromium.org/10933127/diff/6002/chrome/browser/chromeos/con...
chrome/browser/chromeos/contacts/contact_database.h:45:
ContactDatabaseInterface() {}
This constructor is unnecessary, you can't allocate this abstract class because
you have pure virtual methods below.

class I {                                                                       

 public:                                                                        

  virtual void F1() {}                                                          

                                                                                
 
  virtual void F2() = 0;                                                        

                                                                                

 protected:                                                                     

   virtual ~I() {}                                                              
 
};                                                                              

                                                                                
 
void f() {                                                                      

   I* i = new I();                                                              
 
}

void g() {
  I i;
}

$ clang++ -c foo_interface.cc                                                   
                                                                                
                              
foo_interface.cc:12:14: error: allocating an object of abstract class type 'I'
  I* i = new I();
             ^
foo_interface.cc:5:16: note: unimplemented pure virtual method 'F2' in 'I'      
                                                                                
                              
  virtual void F2() = 0;
               ^
foo_interface.cc:16:5: error: variable type 'I' is an abstract class            
                                                                                
                              
  I i;
    ^
2 errors generated.

[commit-bot: I haz the power, 2012-10-10 19:48:04]

Change committed as 161159

[Daniel Erat, 2012-10-10 22:03:25]

https://codereview.chromium.org/11091051/ addresses nits.