Use ICData to collect type feedback on instance setter value. If value is always Smi, insert a smi …

runtime/vm/intermediate_language.h

Index: runtime/vm/intermediate_language.h
===================================================================
--- runtime/vm/intermediate_language.h	(revision 12244)
+++ runtime/vm/intermediate_language.h	(working copy)
@@ -2155,8 +2155,10 @@
 
 class StoreInstanceFieldInstr : public TemplateDefinition<2> {
  public:
-  StoreInstanceFieldInstr(const Field& field, Value* instance, Value* value)
-      : field_(field) {
+  StoreInstanceFieldInstr(const Field& field,
+                          Value* instance,
+                          Value* value)
+      : field_(field), may_need_store_barrier_(true) {

[Vyacheslav Egorov (Google), 2012/09/12 10:43:43]

Is there any reason for not passing it as a parameter to the constructor (and
making it const field?)

[srdjan, 2012/09/12 10:52:52]

Changed as suggested.

     ASSERT(instance != NULL);
     ASSERT(value != NULL);
     inputs_[0] = instance;
@@ -2170,6 +2172,12 @@
 
   Value* instance() const { return inputs_[0]; }
   Value* value() const { return inputs_[1]; }
+  bool may_need_store_barrier() const {
+    return may_need_store_barrier_;
+  }
+  void set_may_need_store_barrier(bool value) {
+    may_need_store_barrier_ = value;
+  }
 
   virtual void PrintOperandsTo(BufferFormatter* f) const;
 
@@ -2178,6 +2186,7 @@
 
  private:
   const Field& field_;
+  bool may_need_store_barrier_;

[Vyacheslav Egorov (Google), 2012/09/12 10:43:43]

I would call it emit_store_barrier_

[srdjan, 2012/09/12 10:52:52]

Done.

 
   DISALLOW_COPY_AND_ASSIGN(StoreInstanceFieldInstr);
 };