Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(504)

Issue 10933014: clang: Remove an ancient workaround. (Closed)

Created:
8 years, 3 months ago by Nico
Modified:
8 years, 3 months ago
Reviewers:
Mark Mentovai, hans
CC:
chromium-reviews, erikwright+watch_chromium.org
Visibility:
Public.

Description

clang: Remove an ancient workaround. This was added 2 years ago when Evan added the initial clang support (http://codereview.chromium.org/522020). It's no longer needed. BUG=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=156002

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -8 lines) Patch
M base/linked_list.h View 2 chunks +1 line, -8 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
Nico
8 years, 3 months ago (2012-09-11 08:46:05 UTC) #1
hans
lgtm
8 years, 3 months ago (2012-09-11 08:59:56 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thakis@chromium.org/10933014/1
8 years, 3 months ago (2012-09-11 09:00:23 UTC) #3
commit-bot: I haz the power
Presubmit check for 10933014-1 failed and returned exit status 1. Running presubmit commit checks ...
8 years, 3 months ago (2012-09-11 09:00:27 UTC) #4
Nico
+mark for owners (if it lgty, can you tick the cq box?)
8 years, 3 months ago (2012-09-11 09:13:11 UTC) #5
Mark Mentovai
LGTM and CQ
8 years, 3 months ago (2012-09-11 12:06:19 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thakis@chromium.org/10933014/1
8 years, 3 months ago (2012-09-11 12:06:36 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thakis@chromium.org/10933014/1
8 years, 3 months ago (2012-09-11 12:26:18 UTC) #8
commit-bot: I haz the power
8 years, 3 months ago (2012-09-11 13:12:50 UTC) #9
Change committed as 156002

Powered by Google App Engine
This is Rietveld 408576698