Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(77)

Unified Diff: base/linked_list.h

Issue 10933014: clang: Remove an ancient workaround. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/linked_list.h
diff --git a/base/linked_list.h b/base/linked_list.h
index 70e90561722586fe13779ddba44e6599553f9b26..5b5184f6253854e1f77321157d9a0535d8623fab 100644
--- a/base/linked_list.h
+++ b/base/linked_list.h
@@ -125,13 +125,6 @@ class LinkNode {
return static_cast<T*>(this);
}
- // Work around a Clang bug reported upstream:
- // http://llvm.org/bugs/show_bug.cgi?id=7974
- // TODO(evanm): remove this and its sole caller.
- void set(LinkNode<T>* prev, LinkNode<T>* next) {
- previous_ = prev; next_ = next;
- }
-
private:
LinkNode<T>* previous_;
LinkNode<T>* next_;
@@ -143,7 +136,7 @@ class LinkedList {
// The "root" node is self-referential, and forms the basis of a circular
// list (root_.next() will point back to the start of the list,
// and root_->previous() wraps around to the end of the list).
- LinkedList() { root_.set(&root_, &root_); }
+ LinkedList() : root_(&root_, &root_) {}
// Appends |e| to the end of the linked list.
void Append(LinkNode<T>* e) {
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698