Fix for http://code.google.com/p/dart/issues/detail?id=5085 - break-on-exceptions in the debugger c…

runtime/bin/dbg_connection.cc

Index: runtime/bin/dbg_connection.cc
===================================================================
--- runtime/bin/dbg_connection.cc	(revision 12267)
+++ runtime/bin/dbg_connection.cc	(working copy)
@@ -433,7 +433,19 @@
   if (Dart_IsNull(object)) {
     text = Dart_Null();
   } else {
+    Dart_ExceptionPauseInfo savedState = Dart_GetExceptionPauseInfo();
+
+    if (savedState != kNoPauseOnExceptions) {

[hausner, 2012/09/12 17:09:59]

Please add

TODO(hausner): Check whether recursive/reentrant pauses on exceptions should be
prevented in Debugger::SignalExceptionThrown() instead.

[devoncarew, 2012/09/12 17:20:52]

Done.

+      Dart_Handle res = Dart_SetExceptionPauseInfo(kNoPauseOnExceptions);
+      ASSERT_NOT_ERROR(res);
+    }
+
     text = Dart_ToString(object);
+
+    if (savedState != kNoPauseOnExceptions) {
+      Dart_Handle res = Dart_SetExceptionPauseInfo(savedState);
+      ASSERT_NOT_ERROR(res);
+    }
   }
   buf->Printf("\"text\":");
   if (Dart_IsNull(text)) {