Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(291)

Unified Diff: chrome/browser/nacl_host/nacl_process_host.h

Issue 10928050: Open socket for NaCl GDB debug stub in browser process. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/nacl_host/nacl_process_host.cc » ('j') | net/base/tcp_listen_socket.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/nacl_host/nacl_process_host.h
===================================================================
--- chrome/browser/nacl_host/nacl_process_host.h (revision 155701)
+++ chrome/browser/nacl_host/nacl_process_host.h (working copy)
@@ -17,6 +17,7 @@
#include "content/public/browser/browser_child_process_host_delegate.h"
#include "googleurl/src/gurl.h"
#include "ipc/ipc_channel_handle.h"
+#include "net/base/tcp_listen_socket.h"
szym 2012/09/11 16:17:24 Don't include this. Instead, forward-declare Socke
halyavin 2012/09/12 14:29:58 SocketDescriptor is not a struct or a class, it ca
class ChromeRenderMessageFilter;
class CommandLine;
@@ -91,6 +92,12 @@
bool LaunchNaClGdb(base::ProcessId pid);
void OnNaClGdbAttached();
#endif
+#if defined(OS_POSIX)
+ // Create bound TCP socket in the browser process so that the NaCl GDB debug
+ // stub can use it to accept incoming connections even when the Chrome sandbox
+ // is enabled.
+ SocketDescriptor GetDebugStubSocketHandle();
+#endif
// Get path to manifest on local disk if possible.
FilePath GetManifestPath();
bool LaunchSelLdr();
« no previous file with comments | « no previous file | chrome/browser/nacl_host/nacl_process_host.cc » ('j') | net/base/tcp_listen_socket.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698