Open socket for NaCl GDB debug stub in browser process.

net/base/tcp_listen_socket.h

Index: net/base/tcp_listen_socket.h
===================================================================
--- net/base/tcp_listen_socket.h	(revision 155701)
+++ net/base/tcp_listen_socket.h	(working copy)
@@ -22,14 +22,14 @@
   static scoped_refptr<TCPListenSocket> CreateAndListen(
       const std::string& ip, int port, StreamListenSocket::Delegate* del);
 
+  // Get raw socket descriptor bound to ip:port.

[szym, 2012/09/11 16:17:24]

"raw socket" might mislead the reader to think the socket is "raw". I suggest
"raw TCP socket descriptor".

[halyavin, 2012/09/12 14:29:58]

Done.

+  static SocketDescriptor CreateAndBind(const std::string& ip, int port);

[szym, 2012/09/11 16:17:24]

I'm okay with that for now, but I think it'd be better if NaCL gdb actually used
a net::StreamListenSocket instead of just getting the SocketDescriptor using
net/.

  protected:

[szym, 2012/09/11 16:17:24]

nit: Blank line before protected: section.

[halyavin, 2012/09/12 14:29:58]

Done.

   friend class scoped_refptr<TCPListenSocket>;
 
   TCPListenSocket(SocketDescriptor s, StreamListenSocket::Delegate* del);
   virtual ~TCPListenSocket();
 
-  static SocketDescriptor CreateAndBind(const std::string& ip, int port);
-
   // Implements StreamListenSocket::Accept.
   virtual void Accept() OVERRIDE;