Remove permission warnings from most tabs and windows APIs.

chrome/test/data/extensions/api_test/permissions/optional/background.js

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 var assertEq = chrome.test.assertEq;
 var assertFalse = chrome.test.assertFalse;
 var assertTrue = chrome.test.assertTrue;
 var fail = chrome.test.callbackFail;
 var pass = chrome.test.callbackPass;
 var listenOnce = chrome.test.listenOnce;
 
 var NOT_OPTIONAL_ERROR =
     "Optional permissions must be listed in extension manifest.";
 
-var NO_TABS_PERMISSION =
-    "You do not have permission to use 'windows.getAll'.";
+var NO_BOOKMARKS_PERMISSION =
+    "You do not have permission to use 'bookmarks.getTree'.";
 
 var REQUIRED_ERROR =
     "You cannot remove required permissions.";
 
 var NOT_WHITE_LISTED_ERROR =
     "The optional permissions API does not support '*'.";
 
 var UNKNOWN_PERMISSIONS_ERROR =
     "'*' is not a recognized permission.";
 
 var emptyPermissions = {permissions: [], origins: []};
 
 var initialPermissions = {
   permissions: ['management'],
   origins: ['http://a.com/*']
 };
 
-var permissionsWithTabs = {
-  permissions: ['management', 'tabs'],
+var permissionsWithBookmarks = {
+  permissions: ['management', 'bookmarks'],
   origins: ['http://a.com/*']
 }
 
 var permissionsWithOrigin = {
   permissions: ['management'],
   origins: ['http://a.com/*', 'http://*.c.com/*']
 }
 
 function checkEqualSets(set1, set2) {
   if (set1.length != set2.length)
@@ skipping 63 matching lines @@
     function requestNoOp() {
       chrome.permissions.request(
           {permissions:['management'], origins:['http://a.com/*']},
           pass(function(granted) { assertTrue(granted); }));
     },
 
     // We should get an error when requesting permissions that haven't been
     // defined in "optional_permissions".
     function requestNonOptional() {
       chrome.permissions.request(
-          {permissions: ['bookmarks']}, fail(NOT_OPTIONAL_ERROR));
+          {permissions: ['history']}, fail(NOT_OPTIONAL_ERROR));
       chrome.permissions.request(
           {origins: ['http://*.b.com/*']}, fail(NOT_OPTIONAL_ERROR));
       chrome.permissions.request(
-          {permissions: ['tabs'], origins: ['http://*.b.com/*']},
+          {permissions: ['history'], origins: ['http://*.b.com/*']},
           fail(NOT_OPTIONAL_ERROR));
     },
 
-    // We should be able to request the tabs API since it's in the granted
+    // We should be able to request the bookmarks API since it's in the granted
     // permissions list (see permissions_apitest.cc).
-    function requestTabs() {
-      // chrome.windows is a optional permission, so the API definition should
+    function requestBookmarks() {
+      // chrome.bookmarks is a optional permission, so the API definition should
       // exist but its use disallowed.
-      assertTrue(!!chrome.windows);
+      assertTrue(!!chrome.bookmarks);
       try {
-        chrome.windows.getAll({populate: true}, function() {
-          chrome.test.fail("Should not have tabs API permission.");
+        chrome.bookmarks.getTree(function() {
+          chrome.test.fail("Should not have bookmarks API permission.");
         });
       } catch (e) {
-        assertTrue(e.message.indexOf(NO_TABS_PERMISSION) == 0);
+        assertTrue(e.message.indexOf(NO_BOOKMARKS_PERMISSION) == 0);
       }
       listenOnce(chrome.permissions.onAdded,
                  function(permissions) {
         assertTrue(permissions.permissions.length == 1);
-        assertTrue(permissions.permissions[0] == 'tabs');
+        assertTrue(permissions.permissions[0] == 'bookmarks');
       });
       chrome.permissions.request(
-          {permissions:['tabs']},
+          {permissions:['bookmarks']},
           pass(function(granted) {
             assertTrue(granted);
-            chrome.windows.getAll({populate: true}, pass(function(windows) {
+            chrome.bookmarks.getTree(pass(function(result) {
               assertTrue(true);
             }));
             chrome.permissions.getAll(pass(function(permissions) {
-              assertTrue(checkPermSetsEq(permissionsWithTabs, permissions));
+              assertTrue(checkPermSetsEq(permissionsWithBookmarks,
+                                         permissions));
             }));
       }));
     },
 
     // These permissions should be on the granted list because they're on the
     // extension's default permission list.
     function requestGrantedPermission() {
       chrome.permissions.request(
           {permissions: ['management'], origins: ['http://a.com/*']},
           pass(function(granted) {
         assertTrue(granted);
       }));
     },
 
     // You can't remove required permissions.
     function removeRequired() {
       chrome.permissions.remove(
           {permissions: ['management']}, fail(REQUIRED_ERROR));
       chrome.permissions.remove(
           {origins: ['http://a.com/*']}, fail(REQUIRED_ERROR));
       chrome.permissions.remove(
-          {permissions: ['tabs'], origins: ['http://a.com/*']},
+          {permissions: ['bookmarks'], origins: ['http://a.com/*']},
           fail(REQUIRED_ERROR));
     },
 
     // You can remove permissions you don't have (nothing happens).
     function removeNoOp() {
       chrome.permissions.remove(
           {permissions:['background']},
           pass(function(removed) { assertTrue(removed); }));
       chrome.permissions.remove(
           {origins:['http://*.c.com/*']},
           pass(function(removed) { assertTrue(removed); }));
       chrome.permissions.remove(
           {permissions:['background'], origins:['http://*.c.com/*']},
           pass(function(removed) { assertTrue(removed); }));
     },
 
-    function removeTabs() {
-      chrome.windows.getAll({populate: true}, pass(function(windows) {
+    function removeBookmarks() {
+      chrome.bookmarks.getTree(pass(function(result) {
         assertTrue(true);
       }));
       listenOnce(chrome.permissions.onRemoved,
                  function(permissions) {
         assertTrue(permissions.permissions.length == 1);
-        assertTrue(permissions.permissions[0] == 'tabs');
+        assertTrue(permissions.permissions[0] == 'bookmarks');
       });
       chrome.permissions.remove(
-          {permissions:['tabs']},
+          {permissions:['bookmarks']},
           pass(function() {
             chrome.permissions.getAll(pass(function(permissions) {
               assertTrue(checkPermSetsEq(initialPermissions, permissions));
             }));
             try {
-              chrome.windows.getAll({populate: true}, function() {
-                chrome.test.fail("Should not have tabs API permission.");
+              chrome.bookmarks.getTree(function() {
+                chrome.test.fail("Should not have bookmarks API permission.");
               });
             } catch (e) {
-              assertTrue(e.message.indexOf(NO_TABS_PERMISSION) == 0);
+              assertTrue(e.message.indexOf(NO_BOOKMARKS_PERMISSION) == 0);
             }
       }));
     },
 
     // The user shouldn't have to approve permissions that have no warnings.
     function noPromptForNoWarnings() {
       chrome.permissions.request(
           {permissions: ['notifications']},
           pass(function(granted) {
         assertTrue(granted);
@@ skipping 68 matching lines @@
             pass(function(result) { assertFalse(result); }));
         doReq('http://c.com', pass(function(result) { assertFalse(result); }));
       }));
     },
 
     // Tests that the changed permissions have taken effect from inside the
     // onAdded and onRemoved event listeners.
     function eventListenerPermissions() {
       listenOnce(chrome.permissions.onAdded,
                  function(permissions) {
-        chrome.windows.getAll({populate: true}, pass(function() {
+        chrome.bookmarks.getTree(pass(function() {
           assertTrue(true);
         }));
       });
       listenOnce(chrome.permissions.onRemoved,
                  function(permissions) {
         try {
-          chrome.windows.getAll({populate: true}, function() {
-            chrome.test.fail("Should not have tabs API permission.");
+          chrome.bookmarks.getTree(function() {
+            chrome.test.fail("Should not have bookmakrs API permission.");
           });
         } catch (e) {
-          assertTrue(e.message.indexOf(NO_TABS_PERMISSION) == 0);
+          assertTrue(e.message.indexOf(NO_BOOKMARKS_PERMISSION) == 0);
         }
       });
 
       chrome.permissions.request(
-          {permissions: ['tabs', 'management']}, pass(function(granted) {
+          {permissions: ['bookmarks', 'management']}, pass(function(granted) {
         assertTrue(granted);
         chrome.permissions.remove(
-            {permissions: ['tabs']}, pass(function() {
+            {permissions: ['bookmarks']}, pass(function() {
           assertTrue(true);
         }));
       }));
     }
 
   ]);
 });