Issue 10920070: Remove permission warnings from most tabs and windows APIs.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10920070: Remove permission warnings from most tabs and windows APIs. (Closed)

Created:
8 years, 3 months ago by Aaron Boodman

Modified:
8 years, 3 months ago

Reviewers:
chebert

CC:
chromium-reviews, mihaip-chromium-reviews_chromium.org, sadrul, ben+watch_chromium.org, tfarina, Dmitry Titov, dcheng, Aaron Boodman, jennb, darin-cc_chromium.org, jianli

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Remove permission warnings from most tabs and windows APIs. Patch contributed by 'Chris Hebert <chebert@chromium.org>'. See http://codereview.chromium.org/10829186/ BUG=137404 TBR=jennb,derat,chebert

Patch Set 1 #

Total comments: 1

Created: 8 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+323 lines, -185 lines)			Patch
M	chrome/browser/extensions/all_urls_apitest.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/extensions/api/messaging/message_service.cc	View	2 chunks	+8 lines, -4 lines	0 comments	Download
M	chrome/browser/extensions/api/permissions/permissions_apitest.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/extensions/api/tabs/tabs.cc	View	17 chunks	+32 lines, -26 lines	0 comments	Download
M	chrome/browser/extensions/api/tabs/tabs_test.cc	View	29 chunks	+45 lines, -5 lines	0 comments	Download
M	chrome/browser/extensions/browser_event_router.h	View	1 chunk	+14 lines, -1 line	1 comment	Download
M	chrome/browser/extensions/browser_event_router.cc	View	2 chunks	+27 lines, -11 lines	0 comments	Download
M	chrome/browser/extensions/browser_extension_window_controller.h	View	2 chunks	+6 lines, -1 line	0 comments	Download
M	chrome/browser/extensions/browser_extension_window_controller.cc	View	1 chunk	+4 lines, -2 lines	0 comments	Download
M	chrome/browser/extensions/event_listener_map.h	View	1 chunk	+5 lines, -2 lines	0 comments	Download
M	chrome/browser/extensions/event_router.h	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	chrome/browser/extensions/event_router.cc	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	chrome/browser/extensions/execute_script_apitest.cc	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	chrome/browser/extensions/extension_tab_util.h	View	1 chunk	+9 lines, -4 lines	0 comments	Download
M	chrome/browser/extensions/extension_tab_util.cc	View	6 chunks	+60 lines, -27 lines	0 comments	Download
M	chrome/browser/extensions/extension_tab_util_android.cc	View	1 chunk	+13 lines, -6 lines	0 comments	Download
M	chrome/browser/extensions/extension_tabs_apitest.cc	View	1 chunk	+2 lines, -3 lines	0 comments	Download
M	chrome/browser/extensions/menu_manager.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/extensions/window_controller.h	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	chrome/browser/ui/panels/panel.cc	View	3 chunks	+9 lines, -5 lines	0 comments	Download
M	chrome/browser/ui/views/ash/panel_view_aura.cc	View	2 chunks	+4 lines, -2 lines	0 comments	Download
M	chrome/common/extensions/api/tabs.json	View	1 chunk	+3 lines, -3 lines	0 comments	Download
M	chrome/common/extensions/docs/examples/api/bookmarks/basic/manifest.json	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/common/extensions/docs/examples/api/browserAction/make_page_red/manifest.json	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/common/extensions/extension_unittest.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/common/extensions/permissions/permission_set.cc	View	2 chunks	+3 lines, -5 lines	0 comments	Download
M	chrome/common/extensions/permissions/permission_set_unittest.cc	View	1 chunk	+4 lines, -3 lines	0 comments	Download
M	chrome/renderer/extensions/dispatcher.cc	View	1 chunk	+1 line, -13 lines	0 comments	Download
M	chrome/test/data/extensions/api_test/active_tab/background.js	View	1 chunk	+3 lines, -1 line	0 comments	Download
M	chrome/test/data/extensions/api_test/all_urls/content_script/manifest.json	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/test/data/extensions/api_test/events/background.js	View	1 chunk	+4 lines, -3 lines	0 comments	Download
M	chrome/test/data/extensions/api_test/permissions/disabled/background.js	View	2 chunks	+9 lines, -5 lines	0 comments	Download
M	chrome/test/data/extensions/api_test/permissions/optional/background.js	View	6 chunks	+32 lines, -31 lines	0 comments	Download
M	chrome/test/data/extensions/api_test/permissions/optional/manifest.json	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/test/data/extensions/api_test/permissions/optional_deny/background.js	View	3 chunks	+7 lines, -7 lines	0 comments	Download
M	chrome/test/data/extensions/api_test/permissions/optional_deny/manifest.json	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/test/data/extensions/api_test/permissions/optional_gesture/background.js	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/test/data/extensions/api_test/permissions/optional_gesture/manifest.json	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages

chebert

8 years, 3 months ago (2012-09-04 15:56:18 UTC) #1

lgoodtm.

Thanks for using my patch! Always glad to help.

heh. Actually my chromium is "hebert.christopherj@". :)

https://chromiumcodereview.appspot.com/10920070/diff/1/chrome/browser/extensi...
File chrome/browser/extensions/browser_event_router.h (right):

https://chromiumcodereview.appspot.com/10920070/diff/1/chrome/browser/extensi...
chrome/browser/extensions/browser_event_router.h:133: // DispatchEvent with a
tab value appended as the last argument.
Idk if it matters, but I think I should have put this comment above the 1st
DispatchEventwithTab() (above).

Expand Messages | Collapse Messages