Issue 10920024: Fix the fixme introduced in crrev.com/154287

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10920024: Fix the fixme introduced in crrev.com/154287 (Closed)

Created:
8 years, 3 months ago by Tom Sepez

Modified:
8 years, 3 months ago

Reviewers:
Charlie Reis, brettw

CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Fix the fixme introduced in crrev.com/154287 The issue is that the an output-only parameter (details.did_replace_entry) has its value upon input used as part of the logic. Changes some functions to make this case more obvious. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=154571

Patch Set 1 #

Created: 8 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+11 lines, -11 lines)			Patch
M	content/browser/web_contents/navigation_controller_impl.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	content/browser/web_contents/navigation_controller_impl.cc	View	6 chunks	+9 lines, -8 lines	0 comments	Download
M	content/browser/web_contents/navigation_controller_impl_unittest.cc	View	1 chunk	+1 line, -2 lines	0 comments	Download