Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(167)

Side by Side Diff: content/browser/web_contents/navigation_controller_impl.h

Issue 10920024: Fix the fixme introduced in crrev.com/154287 (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | content/browser/web_contents/navigation_controller_impl.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CONTENT_BROWSER_WEB_CONTENTS_NAVIGATION_CONTROLLER_IMPL_H_ 5 #ifndef CONTENT_BROWSER_WEB_CONTENTS_NAVIGATION_CONTROLLER_IMPL_H_
6 #define CONTENT_BROWSER_WEB_CONTENTS_NAVIGATION_CONTROLLER_IMPL_H_ 6 #define CONTENT_BROWSER_WEB_CONTENTS_NAVIGATION_CONTROLLER_IMPL_H_
7 7
8 #include "build/build_config.h" 8 #include "build/build_config.h"
9 #include "base/compiler_specific.h" 9 #include "base/compiler_specific.h"
10 #include "base/memory/linked_ptr.h" 10 #include "base/memory/linked_ptr.h"
(...skipping 204 matching lines...) Expand 10 before | Expand all | Expand 10 after
215 // the caller. 215 // the caller.
216 // 216 //
217 // RendererDidNavigateAutoSubframe is special, it may not actually change 217 // RendererDidNavigateAutoSubframe is special, it may not actually change
218 // anything if some random subframe is loaded. It will return true if anything 218 // anything if some random subframe is loaded. It will return true if anything
219 // changed, or false if not. 219 // changed, or false if not.
220 // 220 //
221 // The functions taking |did_replace_entry| will fill into the given variable 221 // The functions taking |did_replace_entry| will fill into the given variable
222 // whether the last entry has been replaced or not. 222 // whether the last entry has been replaced or not.
223 // See LoadCommittedDetails.did_replace_entry. 223 // See LoadCommittedDetails.did_replace_entry.
224 void RendererDidNavigateToNewPage( 224 void RendererDidNavigateToNewPage(
225 const ViewHostMsg_FrameNavigate_Params& params, bool* did_replace_entry); 225 const ViewHostMsg_FrameNavigate_Params& params, bool replace_entry);
226 void RendererDidNavigateToExistingPage( 226 void RendererDidNavigateToExistingPage(
227 const ViewHostMsg_FrameNavigate_Params& params); 227 const ViewHostMsg_FrameNavigate_Params& params);
228 void RendererDidNavigateToSamePage( 228 void RendererDidNavigateToSamePage(
229 const ViewHostMsg_FrameNavigate_Params& params); 229 const ViewHostMsg_FrameNavigate_Params& params);
230 void RendererDidNavigateInPage( 230 void RendererDidNavigateInPage(
231 const ViewHostMsg_FrameNavigate_Params& params, bool* did_replace_entry); 231 const ViewHostMsg_FrameNavigate_Params& params, bool* did_replace_entry);
232 void RendererDidNavigateNewSubframe( 232 void RendererDidNavigateNewSubframe(
233 const ViewHostMsg_FrameNavigate_Params& params); 233 const ViewHostMsg_FrameNavigate_Params& params);
234 bool RendererDidNavigateAutoSubframe( 234 bool RendererDidNavigateAutoSubframe(
235 const ViewHostMsg_FrameNavigate_Params& params); 235 const ViewHostMsg_FrameNavigate_Params& params);
(...skipping 117 matching lines...) Expand 10 before | Expand all | Expand 10 after
353 static size_t max_entry_count_for_testing_; 353 static size_t max_entry_count_for_testing_;
354 354
355 // If a repost is pending, its type (RELOAD or RELOAD_IGNORING_CACHE), 355 // If a repost is pending, its type (RELOAD or RELOAD_IGNORING_CACHE),
356 // NO_RELOAD otherwise. 356 // NO_RELOAD otherwise.
357 ReloadType pending_reload_; 357 ReloadType pending_reload_;
358 358
359 DISALLOW_COPY_AND_ASSIGN(NavigationControllerImpl); 359 DISALLOW_COPY_AND_ASSIGN(NavigationControllerImpl);
360 }; 360 };
361 361
362 #endif // CONTENT_BROWSER_WEB_CONTENTS_NAVIGATION_CONTROLLER_IMPL_H_ 362 #endif // CONTENT_BROWSER_WEB_CONTENTS_NAVIGATION_CONTROLLER_IMPL_H_
OLDNEW
« no previous file with comments | « no previous file | content/browser/web_contents/navigation_controller_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698