Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(119)

Unified Diff: chrome/browser/extensions/api/api_resource_manager_unittest.cc

Issue 10919201: Make sure that a given app/extension requests only its own resources. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Improve tests; fix merge conflicts. Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/api_resource_manager_unittest.cc
diff --git a/chrome/browser/extensions/api/api_resource_manager_unittest.cc b/chrome/browser/extensions/api/api_resource_manager_unittest.cc
new file mode 100644
index 0000000000000000000000000000000000000000..9ab46dec01f554683640f74b19b2c3913750a475
--- /dev/null
+++ b/chrome/browser/extensions/api/api_resource_manager_unittest.cc
@@ -0,0 +1,79 @@
+// Copyright (c) 2012 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "base/file_path.h"
+#include "base/string_util.h"
+#include "chrome/browser/extensions/api/api_resource.h"
+#include "chrome/browser/extensions/api/api_resource_manager.h"
+#include "chrome/browser/extensions/extension_function_test_utils.h"
+#include "chrome/common/extensions/extension.h"
+#include "chrome/common/extensions/extension_test_util.h"
+#include "chrome/test/base/browser_with_test_window_test.h"
+#include "content/public/browser/browser_thread.h"
+#include "testing/gtest/include/gtest/gtest.h"
+#include "chrome/browser/extensions/api/api_resource_event_notifier.h"
+#include "chrome/browser/profiles/profile.h"
+#include "googleurl/src/gurl.h"
+
+namespace utils = extension_function_test_utils;
+
+using content::BrowserThread;
+
+namespace extensions {
+
+class ApiResourceManagerUnitTest : public BrowserWithTestWindowTest {
+ public:
+ virtual void SetUp() {
+ BrowserWithTestWindowTest::SetUp();
+ }
+};
+
+class FakeApiResource : public ApiResource {
+ public:
+ FakeApiResource(const std::string& owner_extension_id,
+ ApiResourceEventNotifier* event_notifier) :
+ ApiResource(owner_extension_id, event_notifier) {}
+ ~FakeApiResource() {}
+};
+
+TEST_F(ApiResourceManagerUnitTest, TwoAppsCannotShareResources) {
+ scoped_ptr<ApiResourceManager<FakeApiResource> > manager(
+ new ApiResourceManager<FakeApiResource>(BrowserThread::UI));
+ scoped_refptr<extensions::Extension> extension_one(
+ utils::CreateEmptyExtension("one"));
+ scoped_refptr<extensions::Extension> extension_two(
+ utils::CreateEmptyExtension("two"));
+
+ const std::string extension_one_id(extension_one->id());
+ const std::string extension_two_id(extension_two->id());
+
+ GURL url_one("url-one");
+ GURL url_two("url-two");
+ scoped_refptr<ApiResourceEventNotifier> event_notifier_one(
+ new ApiResourceEventNotifier(
+ NULL, NULL, extension_one_id, 1111, url_one));
+ scoped_refptr<ApiResourceEventNotifier> event_notifier_two(
+ new ApiResourceEventNotifier(
+ NULL, NULL, extension_two_id, 2222, url_two));
+
+ int resource_one_id = manager->Add(new FakeApiResource(
+ extension_one_id, event_notifier_one.get()));
+ int resource_two_id = manager->Add(new FakeApiResource(
+ extension_two_id, event_notifier_two.get()));
+ CHECK(resource_one_id);
+ CHECK(resource_two_id);
+
+ // Confirm each extension can get its own resource.
+ ASSERT_TRUE(manager->Get(extension_one_id, resource_one_id) != NULL);
+ ASSERT_TRUE(manager->Get(extension_two_id, resource_two_id) != NULL);
+
+ // Confirm neither extension can get the other's resource.
+ ASSERT_TRUE(manager->Get(extension_one_id, resource_two_id) == NULL);
+ ASSERT_TRUE(manager->Get(extension_two_id, resource_one_id) == NULL);
+
+ // And make sure we're not susceptible to any Jedi mind tricks.
+ ASSERT_TRUE(manager->Get(std::string(), resource_one_id) == NULL);
+}
+
+} // namespace extensions
« no previous file with comments | « chrome/browser/extensions/api/api_resource_manager.h ('k') | chrome/browser/extensions/api/serial/serial_api.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698