Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(364)

Side by Side Diff: chrome/browser/extensions/api/api_resource_manager_unittest.cc

Issue 10919201: Make sure that a given app/extension requests only its own resources. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Improve tests; fix merge conflicts. Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
(Empty)
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file.
4
5 #include "base/file_path.h"
6 #include "base/string_util.h"
7 #include "chrome/browser/extensions/api/api_resource.h"
8 #include "chrome/browser/extensions/api/api_resource_manager.h"
9 #include "chrome/browser/extensions/extension_function_test_utils.h"
10 #include "chrome/common/extensions/extension.h"
11 #include "chrome/common/extensions/extension_test_util.h"
12 #include "chrome/test/base/browser_with_test_window_test.h"
13 #include "content/public/browser/browser_thread.h"
14 #include "testing/gtest/include/gtest/gtest.h"
15 #include "chrome/browser/extensions/api/api_resource_event_notifier.h"
16 #include "chrome/browser/profiles/profile.h"
17 #include "googleurl/src/gurl.h"
18
19 namespace utils = extension_function_test_utils;
20
21 using content::BrowserThread;
22
23 namespace extensions {
24
25 class ApiResourceManagerUnitTest : public BrowserWithTestWindowTest {
26 public:
27 virtual void SetUp() {
28 BrowserWithTestWindowTest::SetUp();
29 }
30 };
31
32 class FakeApiResource : public ApiResource {
33 public:
34 FakeApiResource(const std::string& owner_extension_id,
35 ApiResourceEventNotifier* event_notifier) :
36 ApiResource(owner_extension_id, event_notifier) {}
37 ~FakeApiResource() {}
38 };
39
40 TEST_F(ApiResourceManagerUnitTest, TwoAppsCannotShareResources) {
41 scoped_ptr<ApiResourceManager<FakeApiResource> > manager(
42 new ApiResourceManager<FakeApiResource>(BrowserThread::UI));
43 scoped_refptr<extensions::Extension> extension_one(
44 utils::CreateEmptyExtension("one"));
45 scoped_refptr<extensions::Extension> extension_two(
46 utils::CreateEmptyExtension("two"));
47
48 const std::string extension_one_id(extension_one->id());
49 const std::string extension_two_id(extension_two->id());
50
51 GURL url_one("url-one");
52 GURL url_two("url-two");
53 scoped_refptr<ApiResourceEventNotifier> event_notifier_one(
54 new ApiResourceEventNotifier(
55 NULL, NULL, extension_one_id, 1111, url_one));
56 scoped_refptr<ApiResourceEventNotifier> event_notifier_two(
57 new ApiResourceEventNotifier(
58 NULL, NULL, extension_two_id, 2222, url_two));
59
60 int resource_one_id = manager->Add(new FakeApiResource(
61 extension_one_id, event_notifier_one.get()));
62 int resource_two_id = manager->Add(new FakeApiResource(
63 extension_two_id, event_notifier_two.get()));
64 CHECK(resource_one_id);
65 CHECK(resource_two_id);
66
67 // Confirm each extension can get its own resource.
68 ASSERT_TRUE(manager->Get(extension_one_id, resource_one_id) != NULL);
69 ASSERT_TRUE(manager->Get(extension_two_id, resource_two_id) != NULL);
70
71 // Confirm neither extension can get the other's resource.
72 ASSERT_TRUE(manager->Get(extension_one_id, resource_two_id) == NULL);
73 ASSERT_TRUE(manager->Get(extension_two_id, resource_one_id) == NULL);
74
75 // And make sure we're not susceptible to any Jedi mind tricks.
76 ASSERT_TRUE(manager->Get(std::string(), resource_one_id) == NULL);
77 }
78
79 } // namespace extensions
OLDNEW
« no previous file with comments | « chrome/browser/extensions/api/api_resource_manager.h ('k') | chrome/browser/extensions/api/serial/serial_api.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698