Make sure that a given app/extension requests only its own resources.

Make sure that a given app/extension requests only its own resources.

All ApiResources of a given type live in a single pool. Until now, one
app could send arbitrary resource IDs in and get another app's resources
if it were lucky. Now we check that an app is getting back only its own
resources.

Note that this CL could have been shorter if I hadn't decided to break
out the owner_extension_id in ApiResource's constructor. I decided to
do this anyway because the other way to get that information (asking
ApiResourceEventNotifier) violated the Law of Demeter, or even if it
was a technical non-violation, I didn't feel good about relying on
the incidental fact that AREN knew the extension ID. 

Ben for OWNERS
TBR=ben@chromium.org

BUG=142521
TEST=added

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=156149

[miket_OOO, 2012-09-11 00:12:48]

Having update trouble on trybots. Working on that.

[Mihai Parparita -not on Chrome, 2012-09-11 07:18:19]

LGTM

http://codereview.chromium.org/10919201/diff/4002/chrome/browser/extensions/a...
File chrome/browser/extensions/api/api_resource_manager.h (right):

http://codereview.chromium.org/10919201/diff/4002/chrome/browser/extensions/a...
chrome/browser/extensions/api/api_resource_manager.h:13: #include
"chrome/common/extensions/extension.h"
This include seems unncessary (you're just dealing with extension IDs directly
in this file)

http://codereview.chromium.org/10919201/diff/4002/chrome/browser/extensions/a...
chrome/browser/extensions/api/api_resource_manager.h:68: // TODO(miket):
consider partitioning the ID space by extension ID to make it
You can remove this TODO now.

http://codereview.chromium.org/10919201/diff/4002/chrome/browser/extensions/a...
chrome/browser/extensions/api/api_resource_manager.h:79: extension_id ==
resource->owner_extension_id())
This can fit on the previous line.

http://codereview.chromium.org/10919201/diff/4002/chrome/browser/extensions/a...
File chrome/browser/extensions/api/serial/serial_api.cc (right):

http://codereview.chromium.org/10919201/diff/4002/chrome/browser/extensions/a...
chrome/browser/extensions/api/serial/serial_api.cc:127:
manager_->Remove(extension_->id(), id);
Don't feel too strongly about this, but rather than having to repeat the
extension ID every call-site, you may want to add
GetSocket/RemoveSocket(socketId) protected methods to SerialAsyncApiFunction.

(applies for other APIs too)

http://codereview.chromium.org/10919201/diff/4002/chrome/browser/extensions/a...
File chrome/browser/extensions/api/socket/tcp_socket_unittest.cc (right):

http://codereview.chromium.org/10919201/diff/4002/chrome/browser/extensions/a...
chrome/browser/extensions/api/socket/tcp_socket_unittest.cc:76:
tcp_client_socket, "fake_id", notifier));
Extension IDs are always 20 characters long, other tests generally conform to
that (e.g.
http://code.google.com/searchframe#OAMlx_jo-ck/src/chrome/browser/extensions/...)

[miket_OOO, 2012-09-11 16:40:21]

Thanks! I did all this.

[commit-bot: I haz the power, 2012-09-11 19:57:30]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/miket@chromium.org/10919201/5002

[commit-bot: I haz the power, 2012-09-11 22:39:09]

Change committed as 156149