Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(98)

Issue 10919162: [MIPS] Implementation of sel_ldr for MIPS architecture. (Closed)

Created:
8 years, 3 months ago by petarj
Modified:
8 years, 3 months ago
CC:
native-client-reviews_googlegroups.com
Base URL:
http://src.chromium.org/native_client/trunk/src/native_client/
Visibility:
Public.

Description

[MIPS] Implementation of sel_ldr for MIPS architecture. Set of changes needed for sel_ldr support for MIPS architecture. The commit queue is not working for NaCl at the moment, so we are committing with: NOTRY=true However, we have run a try job manually, and it passed fine. BUG= http://code.google.com/p/nativeclient/issues/detail?id=2275 TEST= pnacl/build.sh misc-tools Committed: http://src.chromium.org/viewvc/native_client?view=rev&revision=9827

Patch Set 1 #

Total comments: 56

Patch Set 2 : Patch updated per Mark's comments. #

Total comments: 6

Patch Set 3 : Second update per Mark's comments. #

Total comments: 56

Patch Set 4 : Third update per Mark's comments. #

Patch Set 5 : Minor update. #

Total comments: 8

Patch Set 6 : Final update. #

Patch Set 7 : Rebase #

Patch Set 8 : Minor style issue corrected. #

Total comments: 1

Patch Set 9 : Rebase (Friday night edition). #

Patch Set 10 : Rebase (Saturday morning). #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1471 lines, -95 lines) Patch
M SConstruct View 1 2 3 4 5 6 3 chunks +36 lines, -3 lines 0 comments Download
M site_scons/site_tools/library_deps.py View 1 2 3 4 5 6 2 chunks +9 lines, -1 line 0 comments Download
M src/include/concurrency_ops.h View 1 chunk +6 lines, -0 lines 0 comments Download
M src/include/elf_constants.h View 1 1 chunk +1 line, -1 line 0 comments Download
M src/include/nacl_base.h View 1 2 chunks +11 lines, -0 lines 0 comments Download
M src/include/portability.h View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
A + src/trusted/platform_qualify/arch/mips/nacl_dep_qualify_arch.c View 1 2 3 3 chunks +11 lines, -11 lines 0 comments Download
M src/trusted/platform_qualify/build.scons View 1 1 chunk +3 lines, -0 lines 0 comments Download
A + src/trusted/service_runtime/arch/mips/nacl_app.c View 2 chunks +2 lines, -2 lines 0 comments Download
A src/trusted/service_runtime/arch/mips/nacl_signal_mips.h View 1 chunk +60 lines, -0 lines 0 comments Download
A src/trusted/service_runtime/arch/mips/nacl_switch.S View 1 2 3 1 chunk +77 lines, -0 lines 0 comments Download
A + src/trusted/service_runtime/arch/mips/nacl_switch_to_app_mips.c View 1 2 3 4 5 6 7 2 chunks +16 lines, -7 lines 0 comments Download
A src/trusted/service_runtime/arch/mips/nacl_syscall.S View 1 2 3 1 chunk +129 lines, -0 lines 0 comments Download
A src/trusted/service_runtime/arch/mips/nacl_text_pad_test.S View 1 chunk +252 lines, -0 lines 0 comments Download
A + src/trusted/service_runtime/arch/mips/nacl_tls.c View 1 2 3 4 5 6 7 chunks +21 lines, -14 lines 0 comments Download
A + src/trusted/service_runtime/arch/mips/sel_addrspace_mips.c View 1 3 chunks +9 lines, -8 lines 0 comments Download
A src/trusted/service_runtime/arch/mips/sel_ldr_mips.h View 1 2 3 1 chunk +28 lines, -0 lines 0 comments Download
A src/trusted/service_runtime/arch/mips/sel_ldr_mips.c View 1 2 3 1 chunk +99 lines, -0 lines 0 comments Download
A src/trusted/service_runtime/arch/mips/sel_rt.h View 1 2 3 4 5 1 chunk +122 lines, -0 lines 0 comments Download
A + src/trusted/service_runtime/arch/mips/sel_rt.c View 1 2 3 4 5 6 7 8 5 chunks +38 lines, -29 lines 0 comments Download
A src/trusted/service_runtime/arch/mips/tramp_mips.h View 1 chunk +16 lines, -0 lines 0 comments Download
A src/trusted/service_runtime/arch/mips/tramp_mips.S View 1 2 3 1 chunk +49 lines, -0 lines 0 comments Download
M src/trusted/service_runtime/arch/sel_ldr_arch.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/trusted/service_runtime/build.scons View 1 2 3 4 5 6 5 chunks +21 lines, -2 lines 0 comments Download
M src/trusted/service_runtime/elf_util.c View 1 chunk +2 lines, -0 lines 0 comments Download
M src/trusted/service_runtime/include/bits/wordsize.h View 1 2 3 1 chunk +9 lines, -7 lines 0 comments Download
A src/trusted/service_runtime/linux/mips/sel_segments.c View 1 chunk +25 lines, -0 lines 0 comments Download
M src/trusted/service_runtime/linux/nacl_bootstrap.c View 1 2 3 2 chunks +20 lines, -0 lines 0 comments Download
M src/trusted/service_runtime/linux/nacl_bootstrap.x View 1 chunk +1 line, -0 lines 0 comments Download
A src/trusted/service_runtime/linux/nacl_signal_mips.c View 1 2 3 1 chunk +104 lines, -0 lines 0 comments Download
M src/trusted/service_runtime/nacl.scons View 1 2 3 4 5 6 2 chunks +4 lines, -0 lines 0 comments Download
M src/trusted/service_runtime/nacl_config.h View 1 2 3 1 chunk +19 lines, -0 lines 0 comments Download
M src/trusted/service_runtime/nacl_signal.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/trusted/service_runtime/nacl_signal_common.c View 1 chunk +2 lines, -1 line 0 comments Download
M src/trusted/service_runtime/nacl_syscall_handlers_gen.py View 1 chunk +2 lines, -0 lines 0 comments Download
M src/trusted/service_runtime/posix/nacl_signal.c View 1 2 chunks +9 lines, -0 lines 0 comments Download
M src/trusted/service_runtime/sel_ldr-inl.h View 1 2 chunks +5 lines, -0 lines 0 comments Download
M src/trusted/service_runtime/sel_rt.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/trusted/validator/cpufeatures.h View 1 chunk +5 lines, -0 lines 0 comments Download
M src/trusted/validator/ncvalidate.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/trusted/validator/validator_init.c View 1 chunk +2 lines, -0 lines 0 comments Download
M src/trusted/validator_mips/build.scons View 1 chunk +5 lines, -0 lines 0 comments Download
A src/trusted/validator_mips/cpuid_mips.h View 1 chunk +36 lines, -0 lines 0 comments Download
A + src/trusted/validator_mips/ncvalidate.h View 1 2 3 4 2 chunks +10 lines, -9 lines 0 comments Download
A src/trusted/validator_mips/ncvalidate.cc View 1 2 3 4 5 1 chunk +186 lines, -0 lines 0 comments Download

Messages

Total messages: 39 (0 generated)
petarj
A set of sel_ldr related changes for MIPS architecture.
8 years, 3 months ago (2012-09-07 22:16:00 UTC) #1
Mark Seaborn
Do you have a Git branch somewhere containing all your NaCl changes? That would be ...
8 years, 3 months ago (2012-09-08 02:43:14 UTC) #2
petarj
Second patch set has been uploaded. All comments from Mark have been addressed. http://codereview.chromium.org/10919162/diff/1/SConstruct File ...
8 years, 3 months ago (2012-09-11 16:58:13 UTC) #3
petarj
On 2012/09/08 02:43:14, Mark Seaborn wrote: > Do you have a Git branch somewhere containing ...
8 years, 3 months ago (2012-09-11 16:59:49 UTC) #4
Mark Seaborn
http://codereview.chromium.org/10919162/diff/1/src/include/linux/mips/atomic_ops.h File src/include/linux/mips/atomic_ops.h (right): http://codereview.chromium.org/10919162/diff/1/src/include/linux/mips/atomic_ops.h#newcode22 src/include/linux/mips/atomic_ops.h:22: __asm__ __volatile__("1:\n" On 2012/09/11 16:58:13, petarj wrote: > On ...
8 years, 3 months ago (2012-09-13 19:44:36 UTC) #5
petarj
http://codereview.chromium.org/10919162/diff/1/src/include/linux/mips/atomic_ops.h File src/include/linux/mips/atomic_ops.h (right): http://codereview.chromium.org/10919162/diff/1/src/include/linux/mips/atomic_ops.h#newcode22 src/include/linux/mips/atomic_ops.h:22: __asm__ __volatile__("1:\n" On 2012/09/13 19:44:36, Mark Seaborn wrote: > ...
8 years, 3 months ago (2012-09-14 23:14:48 UTC) #6
Mark Seaborn
http://codereview.chromium.org/10919162/diff/10003/src/trusted/service_runtime/include/bits/wordsize.h File src/trusted/service_runtime/include/bits/wordsize.h (right): http://codereview.chromium.org/10919162/diff/10003/src/trusted/service_runtime/include/bits/wordsize.h#newcode15 src/trusted/service_runtime/include/bits/wordsize.h:15: #if defined(__powerpc64__) || defined(__s390x__) || defined(__arch64__) || \ Can ...
8 years, 3 months ago (2012-09-16 02:46:06 UTC) #7
petarj
Third patch set has been uploaded. All comments have been addressed. http://codereview.chromium.org/10919162/diff/1/src/trusted/service_runtime/arch/mips/sel_rt.h File src/trusted/service_runtime/arch/mips/sel_rt.h (right): ...
8 years, 3 months ago (2012-09-18 00:22:15 UTC) #8
Mark Seaborn
LGTM with the changes below. You can tick the commit box when you've made the ...
8 years, 3 months ago (2012-09-18 03:24:34 UTC) #9
petarj
All comments have been addressed. I will upload the change for pnacl directory separately. @Mark ...
8 years, 3 months ago (2012-09-19 17:27:51 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://nativeclient-status.appspot.com/cq/petarj@mips.com/10919162/19004
8 years, 3 months ago (2012-09-20 01:38:04 UTC) #11
commit-bot: I haz the power
Try job failure for 10919162-19004 (retry) on nacl-lucid32_newlib_dbg for steps "annotate, scons_compile, summary". It's a ...
8 years, 3 months ago (2012-09-20 01:56:12 UTC) #12
Mark Seaborn
LGTM - there's some nits to fix resulting from your last change. https://chromiumcodereview.appspot.com/10919162/diff/2005/src/trusted/service_runtime/arch/mips/sel_ldr_mips.h File src/trusted/service_runtime/arch/mips/sel_ldr_mips.h ...
8 years, 3 months ago (2012-09-20 02:40:42 UTC) #13
petarj
New update. Issue with buildbot fixed too. https://chromiumcodereview.appspot.com/10919162/diff/2005/src/trusted/service_runtime/arch/mips/sel_ldr_mips.h File src/trusted/service_runtime/arch/mips/sel_ldr_mips.h (right): https://chromiumcodereview.appspot.com/10919162/diff/2005/src/trusted/service_runtime/arch/mips/sel_ldr_mips.h#newcode24 src/trusted/service_runtime/arch/mips/sel_ldr_mips.h:24: #define NACL_HALT_OPCODE ...
8 years, 3 months ago (2012-09-20 15:33:00 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://nativeclient-status.appspot.com/cq/petarj@mips.com/10919162/38007
8 years, 3 months ago (2012-09-20 15:33:35 UTC) #15
commit-bot: I haz the power
Failed to apply patch for src/trusted/service_runtime/arch/mips/nacl_tls.c: While running patch -p1 --forward --force; patching file src/trusted/service_runtime/arch/mips/nacl_tls.c ...
8 years, 3 months ago (2012-09-21 05:56:39 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://nativeclient-status.appspot.com/cq/petarj@mips.com/10919162/30006
8 years, 3 months ago (2012-09-21 11:25:08 UTC) #17
commit-bot: I haz the power
Failed to apply patch for src/trusted/service_runtime/arch/mips/sel_rt.c: While running patch -p1 --forward --force; patching file src/trusted/service_runtime/arch/mips/sel_rt.c ...
8 years, 3 months ago (2012-09-22 01:14:00 UTC) #18
Mark Seaborn
https://chromiumcodereview.appspot.com/10919162/diff/30006/src/trusted/service_runtime/arch/mips/sel_rt.c File src/trusted/service_runtime/arch/mips/sel_rt.c (left): https://chromiumcodereview.appspot.com/10919162/diff/30006/src/trusted/service_runtime/arch/mips/sel_rt.c#oldcode50 src/trusted/service_runtime/arch/mips/sel_rt.c:50: __asm__ __volatile__("vmrs %0, fpscr" : "=r" (ntcp->sys_fpscr)); You'll need ...
8 years, 3 months ago (2012-09-22 01:26:14 UTC) #19
petarj
On 2012/09/22 01:26:14, Mark Seaborn wrote: > https://chromiumcodereview.appspot.com/10919162/diff/30006/src/trusted/service_runtime/arch/mips/sel_rt.c > File src/trusted/service_runtime/arch/mips/sel_rt.c (left): > > https://chromiumcodereview.appspot.com/10919162/diff/30006/src/trusted/service_runtime/arch/mips/sel_rt.c#oldcode50 ...
8 years, 3 months ago (2012-09-22 01:33:47 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://nativeclient-status.appspot.com/cq/petarj@mips.com/10919162/36015
8 years, 3 months ago (2012-09-22 01:49:19 UTC) #21
Brad Chen
At some point it may be necessary to give up on the commit queue and ...
8 years, 3 months ago (2012-09-22 03:00:04 UTC) #22
commit-bot: I haz the power
The commit queue went berserk retrying too often for a seemingly flaky test. Builder is ...
8 years, 3 months ago (2012-09-22 03:00:58 UTC) #23
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://nativeclient-status.appspot.com/cq/petarj@mips.com/10919162/36015
8 years, 3 months ago (2012-09-22 10:37:24 UTC) #24
commit-bot: I haz the power
The commit queue went berserk retrying too often for a seemingly flaky test. Builder is ...
8 years, 3 months ago (2012-09-22 11:41:37 UTC) #25
petarj
On 2012/09/22 03:00:04, Brad Chen wrote: > At some point it may be necessary to ...
8 years, 3 months ago (2012-09-22 14:32:17 UTC) #26
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://nativeclient-status.appspot.com/cq/petarj@mips.com/10919162/39007
8 years, 3 months ago (2012-09-22 14:32:54 UTC) #27
commit-bot: I haz the power
The commit queue went berserk retrying too often for a seemingly flaky test. Builder is ...
8 years, 3 months ago (2012-09-22 15:37:03 UTC) #28
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://nativeclient-status.appspot.com/cq/petarj@mips.com/10919162/39007
8 years, 3 months ago (2012-09-22 19:09:50 UTC) #29
commit-bot: I haz the power
The commit queue went berserk retrying too often for a seemingly flaky test. Builder is ...
8 years, 3 months ago (2012-09-22 20:14:06 UTC) #30
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://nativeclient-status.appspot.com/cq/petarj@mips.com/10919162/39007
8 years, 3 months ago (2012-09-23 20:06:06 UTC) #31
commit-bot: I haz the power
The commit queue went berserk retrying too often for a seemingly flaky test. Builder is ...
8 years, 3 months ago (2012-09-23 21:11:53 UTC) #32
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://nativeclient-status.appspot.com/cq/petarj@mips.com/10919162/39007
8 years, 3 months ago (2012-09-23 23:37:00 UTC) #33
commit-bot: I haz the power
The commit queue went berserk retrying too often for a seemingly flaky test. Builder is ...
8 years, 3 months ago (2012-09-24 00:43:59 UTC) #34
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://nativeclient-status.appspot.com/cq/petarj@mips.com/10919162/39007
8 years, 3 months ago (2012-09-24 08:34:07 UTC) #35
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://nativeclient-status.appspot.com/cq/petarj@mips.com/10919162/39007
8 years, 3 months ago (2012-09-24 14:45:23 UTC) #36
commit-bot: I haz the power
Failed to request the patch to try. Please note that binary filesare still unsupported at ...
8 years, 3 months ago (2012-09-24 16:01:03 UTC) #37
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://nativeclient-status.appspot.com/cq/petarj@mips.com/10919162/39007
8 years, 3 months ago (2012-09-24 23:10:56 UTC) #38
commit-bot: I haz the power
8 years, 3 months ago (2012-09-24 23:11:49 UTC) #39
Change committed as 9827

Powered by Google App Engine
This is Rietveld 408576698